Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e tests #646

Merged
merged 36 commits into from
Oct 24, 2022
Merged

Fix e2e tests #646

merged 36 commits into from
Oct 24, 2022

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Oct 19, 2022

sug0 added 25 commits September 21, 2022 13:46
@sug0
Temporarily disable eth bridge e2e tests
34621da
@sug0
Disable eth full node in ledger tests
5840830
@sug0
Add abciplus feature flag to e2e tests
8f9c604
@sug0
Fix e2e test regex matching on fullnodes
1fdd1be
@sug0
Run make fmt
4950c44
@sug0
Fix regex for valid tx in e2e tests
95d71af
@sug0
Add a script to unwrap e2e log output
eb798c9
@sug0
Describe unwrap e2e tests script
7800d90
@sug0
Revert "Fix regex for valid tx in e2e tests"
56350f1 
This reverts commit d8a7d6a.
@sug0
Partially fix ledger_txs_and_queries() e2e test
4babd0b
@sug0
Merge branch 'tiago/ethbridge/remove-ws-cli' into tiago/ethbridge/fix…
a8f69be 
…-e2e-tests
@sug0
Improve logging of namadac in e2e tests
c407015
@sug0
Re-enable ledger_txs_and_queries() e2e test
7b04bad
@sug0
Update Cargo.lock
9e4044b
@sug0
Remove TODO from ledger_txs_and_queries() e2e test
301edab
@sug0
Re-enable and fix run_ledger() e2e test
0ccc346
@sug0
Refactor update config
ef4cada
@sug0
Downgraded problematic deps in Cargo.lock
4e1e8bd
@sug0
More Cargo.lock madness
c7c9754
@sug0
Add missing import
fec843a
@sug0
Fix most e2e tests
161293a
@sug0
Merge tiago/ethbridge/remove-ws-cli
d30b908
@sug0
Merge branch 'tiago/ethbridge/remove-ws-cli' into tiago/ethbridge/fix…
fa2dc59 
…-e2e-tests
@sug0
Merge tiago/ethbridge/impl-events-endpoint
25f6887
@sug0
Wait for Tendermint's RPC server to start in e2e tests
2e685bd
@sug0 sug0 added bug Something isn't working ledger labels Oct 19, 2022
james-chf
james-chf reviewed Oct 19, 2022
View reviewed changes
tests/src/e2e/eth_bridge_tests.rs
Comment on lines +22 to +23
#[ignore]
// this test is outdated, so it is ignored
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep (also badly named...). There was this PR to clean it up (anoma/anoma#1229) but that's a bit stale now probably. This test is still testing something we should continue testing (that a random actor cannot write arbitarily to EthBridge VP storage) but this test needs cleaning up.

@sug0 sug0 mentioned this pull request Oct 21, 2022
Merged
@sug0
Copy link
Collaborator Author

sug0 commented Oct 21, 2022

We might need to port some changes from this PR in main: #661

@sug0
Copy link
Collaborator Author

sug0 commented Oct 23, 2022

I've ran CI a couple of times, after the last fixes I pushed, and it passed every time. We could merge it as is, I guess? what do you think @james-chf @batconjurer

image

@sug0 sug0 marked this pull request as ready for review October 23, 2022 21:10
@sug0 sug0 requested review from james-chf and batconjurer October 23, 2022 21:10
@james-chf
Copy link
Contributor

If the CI job ends up flaking a lot it could become annoying to have to keep restarting it on our PRs. If we notice any super flaky tests though we can temporarily ignore them again and open an issue, so think this PR is good to merge

@sug0 sug0 merged commit 3b6066e into eth-bridge-integration Oct 24, 2022
@sug0 sug0 deleted the tiago/ethbridge/fix-e2e-tests branch October 24, 2022 08:51
This was referenced Oct 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batconjurer batconjurer batconjurer approved these changes

@james-chf james-chf james-chf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ethereum-bridge ledger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sug0 @james-chf @batconjurer