-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implicit VP #592
Merged
Merged
implicit VP #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56f5629
to
c045db2
Compare
The implicit VP is loaded from protocol parameters
c045db2
to
21696a5
Compare
When an implicit account is being used as a source of a tx which it has to sign, the client will first check that its PK is revealed and if not submit it and wait for it before continuing.
d1d60ad
to
2f4c6d2
Compare
pls update wasm |
tzemanovic
added a commit
that referenced
this pull request
Nov 16, 2022
- fix imports in `shared/src/ledger/storage/mod.rs` - update token XAN -> NAM in - `tests/src/e2e/ledger_tests.rs` - `wasm/wasm_source/src/vp_implicit.rs` - remove NFT from `wasm/wasm_source/src/vp_implicit.rs` - added shielded token transfer params in test in - `wasm/wasm_source/src/vp_implicit.rs` * tomas/implicit-vps: changelog: add #592 [ci] wasm checksums update test/e2e: add test for implicit account's PK revealing add manual "reveal-pk" command and automatically reveal when needed vp_prelude: refactor `key::get` to re-use new `storage_api::key::get` wasm/vp_implicit: add support and tests for revealing PK wasm: add tx_reveal_pk test/wasm/vp_implicit: use implicit addresses as vp_owner wasm/vp_implicit: rm change handling from implicit VP test/e2e: add test for transfer from implicit account protocol: allow to use implicit accounts in inner txs storage: load implicit VP from parameters add implicit_vp to protocol parameters and genesis wasm: add vp_implicit from a copy of vp_user
Closed
tzemanovic
commented
Nov 16, 2022
tzemanovic
added a commit
that referenced
this pull request
Nov 17, 2022
* tomas/implicit-vps: Update shared/src/ledger/parameters/mod.rs
tzemanovic
added a commit
that referenced
this pull request
Nov 17, 2022
* bat/native-vp-test-tooling: Update tests/src/vm_host_env/tx.rs [feat]: Add multitoken suppor to the TestTxEnv. Add ability to execute wasm blobs on a TestTxEnv in order to test them with native vps
juped
added a commit
that referenced
this pull request
Nov 30, 2022
… into main * namada/bat/native-vp-test-tooling: Update tests/src/vm_host_env/tx.rs [feat]: Add multitoken suppor to the TestTxEnv. Add ability to execute wasm blobs on a TestTxEnv in order to test them with native vps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8
TODO: