Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namada encoding spec checks #461

Merged
merged 5 commits into from
Sep 10, 2022
Merged

Fix namada encoding spec checks #461

merged 5 commits into from
Sep 10, 2022

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Sep 9, 2022

Should fix CI checks when building docs

@sug0
Copy link
Collaborator Author

sug0 commented Sep 9, 2022

pls update wasm

@sug0 sug0 force-pushed the tiago/ethbridge/fix-vext-schemas branch 2 times, most recently from 07bbada to 3b2ed7a Compare September 9, 2022 10:10
@sug0
Copy link
Collaborator Author

sug0 commented Sep 9, 2022

make -C documentation/docs build is still failing, but this time because mdbook is not found. we probably need a new PR to install the build deps, on the CI side

@james-chf james-chf linked an issue Sep 9, 2022 that may be closed by this pull request
Cannot generate encoding specs for ProtocolTxType #453
Closed
@sug0
Copy link
Collaborator Author

sug0 commented Sep 9, 2022

pls update wasm

@james-chf
Copy link
Contributor

make -C documentation/docs build is still failing, but this time because mdbook is not found. we probably need a new PR to install the build deps, on the CI side

It's been removed recently in main - 9ef7e84

@sug0
Copy link
Collaborator Author

sug0 commented Sep 9, 2022

make -C documentation/docs build is still failing, but this time because mdbook is not found. we probably need a new PR to install the build deps, on the CI side

It's been removed recently in main - 9ef7e84

oh ok! I'll update this accordingly, then

@sug0 sug0 force-pushed the tiago/ethbridge/fix-vext-schemas branch from 3b2ed7a to 684da89 Compare September 9, 2022 13:09
@sug0
Copy link
Collaborator Author

sug0 commented Sep 9, 2022

just as a note, we should still run $(cargo) run --bin namada_encoding_spec somewhere in CI. it caught a bug, where borsh schemas (ethereum_events::VextDigest and validator_set_update::VextDigest) had the same identifier, but different reprs.

@sug0
Copy link
Collaborator Author

sug0 commented Sep 10, 2022

pls update wasm

@sug0 sug0 force-pushed the tiago/ethbridge/fix-vext-schemas branch from a18bcfb to 72d5ca2 Compare September 10, 2022 12:57
@sug0 sug0 merged commit e8e28a1 into eth-bridge-integration Sep 10, 2022
@sug0 sug0 deleted the tiago/ethbridge/fix-vext-schemas branch September 10, 2022 14:27
@sug0 sug0 mentioned this pull request Sep 10, 2022
Closed
@sug0 sug0 mentioned this pull request Oct 25, 2022
Merged
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
@jurevans
Add Ledger approval/rejection handling (anoma#461)
faf638b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batconjurer batconjurer batconjurer approved these changes

@james-chf james-chf james-chf approved these changes

@Fraccaman Fraccaman Awaiting requested review from Fraccaman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot generate encoding specs for ProtocolTxType
4 participants
@sug0 @james-chf @batconjurer @tzemanovic