Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/remove reverse conversions (backport #4290) #4334

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 5, 2025

Describe your changes

An alternative to #4288 where the ability to choose the epoch to which amounts are exchanged to is simply removed. This functionality became redundant once pinned transactions were removed in #3142 . More generally, this functionality is only needed for properly implementing functionality like account statements and pinned transactions where the amounts that were received need to be printed out exactly as they were in the past without any influence from conversions in the current tree.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4290 done by [Mergify](https://mergify.com).

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Feb 5, 2025
@mergify mergify bot merged commit 70a5ed1 into maint-libs-0.47 Feb 5, 2025
11 of 12 checks passed
@mergify mergify bot deleted the mergify/bp/maint-libs-0.47/pr-4290 branch February 5, 2025 15:19
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.18%. Comparing base (37ccfdb) to head (ff6c1d7).
Report is 9 commits behind head on maint-libs-0.47.

Files with missing lines Patch % Lines
crates/core/src/masp.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           maint-libs-0.47    #4334      +/-   ##
===================================================
- Coverage            74.19%   74.18%   -0.02%     
===================================================
  Files                  345      345              
  Lines               110677   110623      -54     
===================================================
- Hits                 82118    82066      -52     
+ Misses               28559    28557       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants