Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: change the derivation path for modified ZIP32 #4307

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tzemanovic
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic requested a review from murisi February 4, 2025 10:29
@tzemanovic tzemanovic marked this pull request as ready for review February 4, 2025 10:29
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.17%. Comparing base (759fcfc) to head (2868f4f).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
crates/wallet/src/lib.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4307      +/-   ##
==========================================
+ Coverage   74.06%   74.17%   +0.11%     
==========================================
  Files         345      345              
  Lines      110193   110608     +415     
==========================================
+ Hits        81611    82042     +431     
+ Misses      28582    28566      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant