Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display transaction fees in normal mode #4218

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Jan 6, 2025

Describe your changes

Updated the test vector generator to require the hardware wallet to display wrapper transaction fees in normal mode. See attached the test vectors (which show what the hardware wallet will be required to display) resulting from this change: testvecs.json . This PR should not be merged before hardware wallet normal mode fee display support is implemented because that would cause the hardware wallet CI tests in this Namada repository to fail.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 74.03%. Comparing base (48fbbf1) to head (1465f26).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4218      +/-   ##
==========================================
- Coverage   74.05%   74.03%   -0.03%     
==========================================
  Files         345      345              
  Lines      110033   110047      +14     
==========================================
- Hits        81489    81476      -13     
- Misses      28544    28571      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi marked this pull request as draft January 6, 2025 13:32
@murisi murisi requested review from grarco and brentstone January 6, 2025 13:46
@murisi murisi force-pushed the murisi/normal-mode-display-tx-fees branch from 3cdb77d to d3a6169 Compare January 30, 2025 17:31
@murisi murisi marked this pull request as ready for review January 30, 2025 17:32
@murisi murisi added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 30, 2025
@mergify mergify bot merged commit a6bc1ec into main Jan 30, 2025
23 of 25 checks passed
@mergify mergify bot deleted the murisi/normal-mode-display-tx-fees branch January 30, 2025 21:00
@tzemanovic tzemanovic added the backport-libs-0.47 Backport libraries to 0.47 maintenance branch label Feb 3, 2025
mergify bot added a commit that referenced this pull request Feb 3, 2025
Display transaction fees in normal mode (backport #4218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.47 Backport libraries to 0.47 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants