-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display transaction fees in normal mode #4218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4218 +/- ##
==========================================
- Coverage 74.05% 74.03% -0.03%
==========================================
Files 345 345
Lines 110033 110047 +14
==========================================
- Hits 81489 81476 -13
- Misses 28544 28571 +27 ☔ View full report in Codecov by Sentry. |
grarco
approved these changes
Jan 7, 2025
murisi
force-pushed
the
murisi/normal-mode-display-tx-fees
branch
from
January 30, 2025 17:31
3cdb77d
to
d3a6169
Compare
murisi
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Jan 30, 2025
3 tasks
tzemanovic
added
the
backport-libs-0.47
Backport libraries to 0.47 maintenance branch
label
Feb 3, 2025
This was referenced Feb 3, 2025
mergify bot
added a commit
that referenced
this pull request
Feb 3, 2025
Display transaction fees in normal mode (backport #4218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-libs-0.47
Backport libraries to 0.47 maintenance branch
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updated the test vector generator to require the hardware wallet to display wrapper transaction fees in normal mode. See attached the test vectors (which show what the hardware wallet will be required to display) resulting from this change: testvecs.json . This PR should not be merged before hardware wallet normal mode fee display support is implemented because that would cause the hardware wallet CI tests in this Namada repository to fail.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo