Harden max proposal bytes configuration and deserialization #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a105902 to
ad9482b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3220 +/- ##
=======================================
Coverage 60.24% 60.24%
=======================================
Files 303 303
Lines 93191 93199 +8
=======================================
+ Hits 56145 56152 +7
- Misses 37046 37047 +1 ☔ View full report in Codecov by Sentry. |
e1712cc to
ca6aaa8
Compare
max_tx_bytes provided by CometBFT when initializing block allocatorca6aaa8 to
d8f959c
Compare
batconjurer
approved these changes
May 10, 2024
cwgoes
approved these changes
May 10, 2024
| @@ -475,12 +472,13 @@ async fn write_tm_genesis( | |||
| .try_into() | |||
| .expect("Failed to convert initial genesis height"); | |||
| } | |||
| const EVIDENCE_AND_PROTOBUF_OVERHEAD: u64 = 10 * 1024 * 1024; | |||
| let size = block::Size { | |||
| // maximum size of a serialized Tendermint block. | |||
There was a problem hiding this comment.
Comment is now out of date
tzemanovic
approved these changes
May 14, 2024
tzemanovic
added a commit
that referenced
this pull request
May 14, 2024
* origin/tiago/max-proposal-bytes-validation: Changelog for #3220 Avoid using hardcoded values when configuring CometBFT Validate borsh deserialization of ProposalBytes
tzemanovic
added a commit
that referenced
this pull request
May 14, 2024
brentstone
added a commit
that referenced
this pull request
May 21, 2024
* origin/tiago/max-proposal-bytes-validation: Changelog for #3220 Avoid using hardcoded values when configuring CometBFT Validate borsh deserialization of ProposalBytes
brentstone
added a commit
that referenced
this pull request
May 21, 2024
tzemanovic
added a commit
that referenced
this pull request
May 21, 2024
* tomas/split-up-apps: changelog: add #3259 test/apps_lib: fix the top-level dir check fix paths for split up namada_apps_lib git: ignore the new generated version.rs path symlink proto from `apps_lib` `mv crates/apps/build.rs crates/apps_lib/` `mv crates/apps_lib/src/lib/mod.rs crates/apps_lib/src/lib.rs` `mv crates/apps/src/lib crates/apps_lib/src` apps_lib: add a new crate for apps lib crate fixup! Merge branch 'grarco/masp-fees' (#3217) fixup! Merge branch 'grarco/tx-batch' (#3103) fixup! Merge branch 'grarco/tx-batch' (#3103) fixup! Merge branch 'bat/fix/issue-1796' (#3226) fixup! Merge branch 'tiago/max-proposal-bytes-validation' (#3220) fixup! Merge branch 'tomas/more-checked-arith' (#3214) empty commit changelog: add #3216 deliberatly empty Changelog #2817 added clone to transaction structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3189
Indeed, Namada ignores the
max_tx_bytesparameter from CometBFT, which may shrink dynamically based on the presence of evidence of misbehavior data in blocks.This parameter is only passed as an argument to
PrepareProposalABCI calls, and (crucially) never toProcessProposalcalls, forcing it to be available underProcessProposalvia some other means.As such,
max_proposal_bytes(a semantically equivalent Namada-only parameter) was introduced in #843. To ensure the application never exceedsmax_tx_bytes, CometBFT was configured with a much larger maximum block size (100 MiB, and 90 MiB max formax_proposal_bytes).In #2187, we modified these bounds, setting the max block size to 16 MiB and the max value of
max_proposal_bytesto 6 MiB. Evidence data is the only reason the space reserved for txs may shrink; as 10 MiB is plenty of available space for misbehavior reports, we should never exceed the maximum block size.It is also important to state CometBFT faces a problem of the same nature. During CometBFT block validation,
MaxTxBytesis never checked. The only place where it is checked is during block construction, leaving the burden of this validation to ABCI apps. Unfortunately, as we stated,ProcessProposalis not called withmax_tx_bytes...That said, this PR does the following:
BorshDeserializeforProposalBytes.ProposalBytes::MAXinstead.Indicate on which release or other PRs this topic is based on
v0.35.1Checklist before merging to
draft