Clean up init/join network CLI commands #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3196 +/- ##
==========================================
- Coverage 60.24% 60.24% -0.01%
==========================================
Files 303 303
Lines 93191 93199 +8
==========================================
- Hits 56145 56144 -1
- Misses 37046 37055 +9 ☔ View full report in Codecov by Sentry. |
0c48967 to
e74d50a
Compare
cd94df9 to
e43acdc
Compare
|
maybe we should delete |
891c530 to
35b8ca6
Compare
batconjurer
previously approved these changes
May 10, 2024
tzemanovic
reviewed
May 10, 2024
35b8ca6 to
a61cbed
Compare
tzemanovic
approved these changes
May 10, 2024
brentstone
added a commit
that referenced
this pull request
May 10, 2024
* tiago/chain-init-cleanup: Changelog for #3196 Remove unused global args in `init-network` scripts/gen_localnet.py: Parse epoch duration scripts/gen_localnet.py: Organize CLI args scripts/gen_localnet.py: Support multiple validators scripts/gen_localnet.py: Remove chain id from cmd str scripts/gen_localnet.py: Log which validator is joining network scripts/gen_localnet.py: Add colored output scripts/gen_localnet.py: Use modified templates scripts/gen_localnet.py: Move `init-network` to fn scripts/gen_localnet.py: Copy pre-genesis wallet to validator dir scripts/gen_localnet.py: Generalize `join-network` scripts/gen_localnet.py: Make script executable scripts/gen_localnet.py: Refactor to improve code quality scripts/gen_localnet.py: Move code to main function scripts/gen_localnet.py: Format code Remove fetch wasms CLI cmd Optionally add persistent peers to CometBFT Introduce helper fns to fetch wasm artifacts dir Rework `fetch-wasms` command Fix `join-network` in light of `init-network` changes Fix `init-network` in integration tests Return path to release archive from `init-network` Skip nonexistent wasm artifacts in `init-network` Only emit chain dist archive from `init-network` Do not include base dir in chain dist archive Stop copying wasm checksums twice to chain dist archive Package wasm artifacts with chain dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2423
Clean up the logic around
init-networkandjoin-network.init-networkno longer leaves behind a residual directory, it only outputs an archive with the chain data..namadadirectory, only its contents.join-networkno longer configures CometBFT with persistent peers derived from genesis files by default, this is now gated behind the flag--add-persistent-peers.fetch-wasmscommand which is somewhat redundant and was broken.gen_localnet.pygen_localnet.pyIndicate on which release or other PRs this topic is based on
v0.35.1Checklist before merging to
draft