-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prohibit governance voting from jailed and inactive validators #3004
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
+ Coverage 53.44% 55.14% +1.69%
==========================================
Files 310 309 -1
Lines 101574 102816 +1242
==========================================
+ Hits 54288 56694 +2406
+ Misses 47286 46122 -1164 ☔ View full report in Codecov by Sentry. |
6e1184c
to
bdfe46c
Compare
* brent/jailed-inactive-vals-no-voting: fix proposal_submission e2e test fix good validator collection in client fix VPs changelog: add #3004 safer state checking client: prohibit votes from jailed and inactive validators read total active stake (exclude jailed + inactive) ignore jailed and inactive validators when computing tally active total deltas (voting power) - exclude jailed and inactive validators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'd maybe just rename all the active_voting_power
occurrences to total_deltas_sums
(as in epoched sums of all validators' total deltas)
* origin/brent/jailed-inactive-vals-no-voting: fix proposal_submission e2e test fix good validator collection in client fix VPs changelog: add #3004 safer state checking client: prohibit votes from jailed and inactive validators read total active stake (exclude jailed + inactive) ignore jailed and inactive validators when computing tally active total deltas (voting power) - exclude jailed and inactive validators
* origin/brent/jailed-inactive-vals-no-voting: rename total_active_voting_power --> total_active_deltas
* origin/brent/jailed-inactive-vals-no-voting: rename total_active_voting_power --> total_active_deltas fix proposal_submission e2e test fix good validator collection in client fix VPs changelog: add #3004 safer state checking client: prohibit votes from jailed and inactive validators read total active stake (exclude jailed + inactive) ignore jailed and inactive validators when computing tally active total deltas (voting power) - exclude jailed and inactive validators
Describe your changes
Closes #2796.
Indicate on which release or other PRs this topic is based on
Based on #2877, which is based on 0.32.0.
diff https://github.com/anoma/namada/pull/3004/files/5c0fbeb6ef60c41e8837dfd56fc91751ccd8bac7..5e490ab9dab3ab4dea64407f31d2deef98a9d25e
Checklist before merging to
draft