fix non-persisted diffs #2964
Merged
fix non-persisted diffs #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb33044 to
54b6052
Compare
54b6052 to
6871679
Compare
6871679 to
8dd8d37
Compare
tzemanovic
added a commit
that referenced
this pull request
Apr 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
==========================================
+ Coverage 53.44% 53.48% +0.03%
==========================================
Files 310 310
Lines 101574 101599 +25
==========================================
+ Hits 54288 54340 +52
+ Misses 47286 47259 -27 ☔ View full report in Codecov by Sentry. |
yito88
reviewed
Apr 3, 2024
yito88
approved these changes
Apr 3, 2024
9cad008 to
58883a3
Compare
tzemanovic
added a commit
that referenced
this pull request
Apr 3, 2024
* tomas/fix-non-persisted-diffs: changelog: add #2964 test/DB: update rocksdb diffs and rollback tests DB: prune non-persisted diffs from prev block on every new block commit rocksdb: separate non-persisted diffs into new "rollback" column family core/storage: add `BlockHeight::checked_prev`
tzemanovic
added a commit
that referenced
this pull request
Apr 3, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/tomas/fix-non-persisted-diffs: changelog: add #2964 test/DB: update rocksdb diffs and rollback tests DB: prune non-persisted diffs from prev block on every new block commit rocksdb: separate non-persisted diffs into new "rollback" column family core/storage: add `BlockHeight::checked_prev`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #2955
TODO
Indicate on which release or other PRs this topic is based on
0.32.1
Checklist before merging to
draft