Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Migration tooling #2835

Merged
31 commits merged into from
Mar 19, 2024
Merged

DB Migration tooling #2835

31 commits merged into from
Mar 19, 2024

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Mar 7, 2024

Describe your changes

Adds to tools to create json files to change db keys and various debugging and dry running logic.

Indicate on which release or other PRs this topic is based on

#2814 + #2839 (diff https://github.com/anoma/namada/pull/2835/files/8e709dbcd358dbda44d4f90c9145cd7cf7002335..0a932371f906e3d9a78690749d9b8a8883f36126)
#2839

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@batconjurer batconjurer requested review from sug0 and tzemanovic March 7, 2024 11:27
@brentstone brentstone mentioned this pull request Mar 7, 2024
10 tasks
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 8.88099% with 1026 lines in your changes are missing coverage. Please review.

Project coverage is 53.39%. Comparing base (cc3edde) to head (c215db7).

Files Patch % Lines
crates/sdk/src/migrations.rs 0.00% 223 Missing ⚠️
crates/apps/src/lib/node/ledger/storage/rocksdb.rs 0.00% 137 Missing ⚠️
crates/apps/src/lib/cli.rs 0.00% 100 Missing ⚠️
crates/apps/src/lib/node/ledger/mod.rs 4.61% 62 Missing ⚠️
crates/governance/src/cli/onchain.rs 0.00% 32 Missing ⚠️
crates/storage/src/mockdb.rs 0.00% 32 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/init_chain.rs 6.45% 29 Missing ⚠️
crates/apps/src/bin/namada-node/cli.rs 0.00% 28 Missing ⚠️
crates/proof_of_stake/src/types/mod.rs 0.00% 25 Missing ⚠️
crates/macros/src/lib.rs 71.25% 23 Missing ⚠️
... and 65 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2835      +/-   ##
==========================================
- Coverage   53.88%   53.39%   -0.49%     
==========================================
  Files         308      310       +2     
  Lines      100154   101205    +1051     
==========================================
+ Hits        53967    54041      +74     
- Misses      46187    47164     +977     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic force-pushed the bat/feat/db-migration branch from 0a93237 to a8537c6 Compare March 8, 2024 08:50
@brentstone brentstone mentioned this pull request Mar 8, 2024
tzemanovic
tzemanovic previously approved these changes Mar 8, 2024
@brentstone brentstone force-pushed the bat/feat/db-migration branch from 3b82a18 to c215db7 Compare March 8, 2024 18:32
brentstone added a commit that referenced this pull request Mar 8, 2024
* bat/feat/db-migration:
  Finished rebasing
  [fix]: Make migrations enabled by default
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  [feat]: Added a pattern matching iterator to the db
  [chore]: Added changelog
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Fixed and tested migration tooling.
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  Addressing review comments
  [feat]: Featured gated migrations code
  [feat]: Added a new derive macro to register deserializers of types to a global map
brentstone added a commit that referenced this pull request Mar 9, 2024
* origin/bat/feat/db-migration:
  Finished rebasing
  [fix]: Make migrations enabled by default
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  [feat]: Added a pattern matching iterator to the db
  [chore]: Added changelog
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Fixed and tested migration tooling.
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  Addressing review comments
  [feat]: Featured gated migrations code
  [feat]: Added a new derive macro to register deserializers of types to a global map
@brentstone brentstone mentioned this pull request Mar 9, 2024
2 tasks
brentstone added a commit that referenced this pull request Mar 18, 2024
* origin/bat/feat/db-migration:
  Finished rebasing
  [fix]: Make migrations enabled by default
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  [feat]: Added a pattern matching iterator to the db
  [chore]: Added changelog
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Fixed and tested migration tooling.
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  Addressing review comments
  [feat]: Featured gated migrations code
  [feat]: Added a new derive macro to register deserializers of types to a global map
brentstone added a commit that referenced this pull request Mar 18, 2024
* origin/bat/feat/db-migration:
  Finished rebasing
  [fix]: Make migrations enabled by default
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Added pattern based db migration. Added e2e test and better examples.
  [feat]: Added a pattern matching iterator to the db
  [chore]: Added changelog
  tinies
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  [feat]: Fixed and tested migration tooling.
  [feat]: Rebased on the serializers branch and added cli command to apply db changes from a json file
  Addressing review comments
  [feat]: Featured gated migrations code
  [feat]: Added a new derive macro to register deserializers of types to a global map
@brentstone brentstone closed this pull request by merging all changes into main in 5e0b162 Mar 19, 2024
@brentstone brentstone deleted the bat/feat/db-migration branch March 19, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants