Add tx sechashes as entropy src for established acct addr gen #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
- Coverage 53.95% 53.95% -0.01%
==========================================
Files 308 308
Lines 100018 100025 +7
==========================================
+ Hits 53967 53969 +2
- Misses 46051 46056 +5 ☔ View full report in Codecov by Sentry. |
|
@grarco do we need to update gas costs? |
We'll recompute everything before mainnet, it's fine for now 👍🏻 |
tzemanovic
approved these changes
Mar 8, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* origin/tiago/addr-generator-randomness: Changelog for #2781 Add entropy source to `tx_init_account` More addr gen refactoring Refactor `EstablishedAddressGen::generate_address` Lazily clone storage addr gen
grarco
approved these changes
Apr 4, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/tiago/addr-generator-randomness: Changelog for #2781 Add entropy source to `tx_init_account` More addr gen refactoring Refactor `EstablishedAddressGen::generate_address` Lazily clone storage addr gen # Conflicts: # wasm/wasm_source/src/tx_init_account.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #7
Adds a transaction's code and data section hashes as additional sources of entropy, to compute an established account's address.
Indicate on which release or other PRs this topic is based on
v0.31.8Checklist before merging to
draft