Refactor PD Controller #2575
Merged
Refactor PD Controller #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb44f61 to
4fa7479
Compare
98e3638 to
55c132a
Compare
brentstone
added a commit
that referenced
this pull request
Feb 24, 2024
55c132a to
6c04bd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
+ Coverage 53.44% 53.51% +0.07%
==========================================
Files 310 310
Lines 101574 101648 +74
==========================================
+ Hits 54288 54401 +113
+ Misses 47286 47247 -39 ☔ View full report in Codecov by Sentry. |
brentstone
added a commit
that referenced
this pull request
Feb 28, 2024
6bfbb4d to
72e3002
Compare
brentstone
added a commit
that referenced
this pull request
Mar 3, 2024
72e3002 to
0c814ca
Compare
10 tasks
tzemanovic
reviewed
Apr 2, 2024
tzemanovic
pushed a commit
that referenced
this pull request
Apr 2, 2024
353adca to
bb71767
Compare
tzemanovic
previously approved these changes
Apr 2, 2024
bb71767 to
ad5e8ca
Compare
brentstone
added a commit
that referenced
this pull request
Apr 3, 2024
* brent/refactor-pd-controller: update tingz fix refactors wip: refactor changelog: add #2575 remove old inflation code refactor tests replace shielded inflation replace pos inflation beginning boilerplate with computation
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/brent/refactor-pd-controller: update tingz fix refactors wip: refactor changelog: add #2575 remove old inflation code refactor tests replace shielded inflation replace pos inflation beginning boilerplate with computation # Conflicts: # crates/proof_of_stake/src/rewards.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2553.
Indicate on which release or other PRs this topic is based on
Based on #2559, which is based on v0.32.1
diff: https://github.com/anoma/namada/pull/2575/files/46c88c041fcd76aabad6c21d0ae6b9abe4854917..bb7176783090c18a77d167ce07a826960517ead0
Checklist before merging to
draft