Rebase mariari/key parsing fix #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the key would always parse, even if the string is empty, this causes an issue where if we wanted an Optional Key, then it would always be parsed as Some, causing issues for various parts of the system.
e993e25 to
1003d3b
Compare
1003d3b to
4232b87
Compare
Fraccaman
added a commit
that referenced
this pull request
Jun 15, 2023
* origin/fraccaman+mariari/key-parsing-fix: added changelog [fix]: Fixed unit tests that failed on parsing empty strings as keys Fix Key from always parsing
Closed
Fraccaman
added a commit
that referenced
this pull request
Jun 16, 2023
* origin/fraccaman+mariari/key-parsing-fix: added changelog [fix]: Fixed unit tests that failed on parsing empty strings as keys Fix Key from always parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.