Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build clean up #1571

Merged
merged 13 commits into from
Jun 20, 2023
Merged

build clean up #1571

merged 13 commits into from
Jun 20, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jun 15, 2023

based on 0.17.2

partially completes #1562:

workspace inheritance TLDR:

  • declare deps in root Cargo.toml, in crates use .workspace = true
  • can be used for all [dependencies], [dev/build-dependencies], except for optional deps
  • features are additive

@tzemanovic tzemanovic marked this pull request as ready for review June 15, 2023 09:24
@tzemanovic tzemanovic marked this pull request as draft June 15, 2023 15:03
@tzemanovic tzemanovic force-pushed the tomas/build-clean-up branch from 3300dc6 to 0c53786 Compare June 15, 2023 15:04
@tzemanovic tzemanovic marked this pull request as ready for review June 15, 2023 15:05
tzemanovic added a commit that referenced this pull request Jun 19, 2023
* tomas/build-clean-up:
  wasm: update checksums
  deps: switch workspace packages inheritance
  crates: use workspace inheritance for package metadata
  ci: run `make check-crates` to check build with default features
  make: add a recipe to `check-crates`
  tests: fix namada_tests crate build with default features
  encoding_spec: fix namada_encoding_spec crate build with default features
  apps: fix namada_apps crate build with default features
  shared: fix namada crate build with default features
  core: fix namada_core crate build with default features
  deps: remove tendermint-rs, ibc-rs and tower-abci patches
  update bellman and bls12_381 to rm funty patch
  deps: remove polling patches
@tzemanovic tzemanovic mentioned this pull request Jun 19, 2023
Fraccaman added a commit that referenced this pull request Jun 20, 2023
* origin/tomas/build-clean-up:
  wasm: update checksums
  deps: switch workspace packages inheritance
  crates: use workspace inheritance for package metadata
  ci: run `make check-crates` to check build with default features
  make: add a recipe to `check-crates`
  tests: fix namada_tests crate build with default features
  encoding_spec: fix namada_encoding_spec crate build with default features
  apps: fix namada_apps crate build with default features
  shared: fix namada crate build with default features
  core: fix namada_core crate build with default features
  deps: remove tendermint-rs, ibc-rs and tower-abci patches
  update bellman and bls12_381 to rm funty patch
  deps: remove polling patches
@Fraccaman Fraccaman merged commit fb293e4 into main Jun 20, 2023
@Fraccaman Fraccaman deleted the tomas/build-clean-up branch June 20, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants