Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BasisPoints in favor of using the rust_decimal #456

Closed
brentstone opened this issue Sep 8, 2022 · 1 comment
Closed

Remove BasisPoints in favor of using the rust_decimal #456

brentstone opened this issue Sep 8, 2022 · 1 comment
Assignees
@brentstone
Labels
PoS

Comments

@brentstone
Copy link
Collaborator

The BasisPoints struct used previously to do some decimal multiplication with integers is no longer needed with the use of the rust_decimal crate. Replacing BasisPoints with rust_decimal::Decimal will increase the precision of some simple calculations and also allow for cleaner code.
@brentstone brentstone self-assigned this Sep 8, 2022
@tzemanovic tzemanovic added the PoS label Sep 9, 2022
@brentstone brentstone mentioned this issue Sep 9, 2022
Closed
This was referenced Oct 27, 2022
Closed
Merged
@brentstone
Copy link
Collaborator Author

Closed by #708.

phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@emccorson
chore: bump yarn to v4 (anoma#456)
53fb5e5 
This is to stop the extension build on the CI from failing due to yarn
v1 problems.

This also adds `web-ext` to `devDependencies`, so it no longer needs to
be installed globally.
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@emccorson
chore: build extension in CI on PR (anoma#456)
6a37c86
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@emccorson
chore: fix CI warnings with actions/checkout@v2 (anoma#456)
c1292e3
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@emccorson
chore: fix main CI workflow broken by anoma#456 and rename
5eaa828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentstone brentstone

Labels
PoS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inflation system and PoS rewards anoma/namada
2 participants
@tzemanovic @brentstone