Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make governance parameters for the Ethereum bridge contract addresses #365

Closed
james-chf opened this issue Aug 21, 2022 · 1 comment
Closed

Comments

@james-chf
Copy link
Contributor

james-chf commented Aug 21, 2022

Currently we hardcode dummy Ethereum addresses for a couple of the bridge smart contracts

/// Dummy addresses for smart contracts
const MINT_CONTRACT: EthAddress = EthAddress([0; 20]);
const GOVERNANCE_CONTRACT: EthAddress = EthAddress([1; 20]);

We should instead have a governance parameter for the Ethereum address of the "proxy" smart contract and use that for getting the "bridge" and "governance" smart contract addresses. This should be initialized to the zero Ethereum address at genesis as the Ethereum bridge should not launch straight away at chain launch. The Ethereum oracle component should switch away from using the hardcoded dummy addresses.

We should also have a parameter for the wnam ERC20 contract address.

@james-chf james-chf moved this to Todo in Namada-Old Aug 21, 2022
@james-chf james-chf added good first issue Good for newcomers and removed prio:low labels Sep 7, 2022
@james-chf james-chf changed the title Make a governance parameter for the Ethereum bridge smart contract address Make a governance parameter for the Ethereum bridge proxy contract address Oct 7, 2022
@james-chf james-chf self-assigned this Oct 10, 2022
@james-chf james-chf moved this from Todo to WIP in Namada-Old Oct 10, 2022
@james-chf james-chf changed the title Make a governance parameter for the Ethereum bridge proxy contract address Make governance parameters for the Ethereum bridge contract addresses Oct 10, 2022
@james-chf james-chf removed the good first issue Good for newcomers label Oct 10, 2022
@james-chf
Copy link
Contributor Author

Will start being used in #686

Repository owner moved this from WIP to Tested in Devnet in Namada-Old Oct 26, 2022
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
Force-merging as I'm running solo for a couple weeks :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

1 participant