check if rate > 1 in lib code

anoma · Oct 11, 2023 · 66a7567 · 66a7567
1 parent 2e84ddc
commit 66a7567
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/proof_of_stake/src/lib.rs b/proof_of_stake/src/lib.rs
@@ -176,6 +176,10 @@ pub enum SlashError {
 pub enum CommissionRateChangeError {
     #[error("Unexpected negative commission rate {0} for validator {1}")]
     NegativeRate(Dec, Address),
+    #[error(
+        "Unexpected commission rate {0} larger than 1.0 for validator {1}"
+    )]
+    LargerThanOne(Dec, Address),
     #[error("Rate change of {0} is too large for validator {1}")]
     RateChangeTooLarge(Dec, Address),
     #[error(
@@ -2363,6 +2367,14 @@ where
         .into());
     }
 
+    if new_rate > Dec::one() {
+        return Err(CommissionRateChangeError::LargerThanOne(
+            new_rate,
+            validator.clone(),
+        )
+        .into());
+    }
+
     let max_change =
         read_validator_max_commission_rate_change(storage, validator)?;
     if max_change.is_none() {