Namadillo: Creating Docker setup #927
Conversation
fc18ecc to
35c12dd
Compare
35c12dd to
1ddea3f
Compare
1ddea3f to
d39abbf
Compare
d39abbf to
ec5e0a8
Compare
| @@ -22,6 +22,7 @@ | |||
| "framer-motion": "^11.0.28", | |||
| "idb-keyval": "^6.2.1", | |||
| "invariant": "^2.2.4", | |||
| "io-ts": "^2.2.21", | |||
There was a problem hiding this comment.
@pedrorezende Seems that all of the CI is failing due to this. Maybe we just need to update the yarn.lock file?
There was a problem hiding this comment.
Thanks @jurevans I missed the yarn.lock on my commit!
|
@pedrorezende thanks, lgtm! |
There was a problem hiding this comment.
Looks good! The only question I have is about how this will be used. If we get bug reports from the GitHub releases built through the CI, it should be easy to track down which version is the problem, but I'm not sure whether that will be the case for Docker builds from main. But I don't know, maybe it's not worth worrying about.
|
I think the idea is to have a different option to host Namadillo, once Docker is widely used. Also, the CI is generating the build, so we can do whatever we want with that package. On the other hand, the Docker image configures everything we need. |
This PR introduces the first version of a Dockerfile for Namadillo
Closes #926