feat: add optimistic response for shielded transfers #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorezende
approved these changes
Feb 10, 2025
| @@ -107,7 +107,7 @@ export const viewingKeysAtom = atomWithQuery< | |||
| }); | |||
|
|
|||
| export const storageShieldedBalanceAtom = atomWithStorage< | |||
| Record<Address, { address: string; minDenomAmount: BigNumber }[]> | |||
| Record<Address, { address: Address; minDenomAmount: string }[]> | |||
There was a problem hiding this comment.
I think we should store amount as BigNumber and save unnecessary conversions later
There was a problem hiding this comment.
@pedrorezende I agree, but this is the storage, meaning it's saving on LocalStorage as a string, so, unfortunately, we can't save it as a BigNumber
I found this issue because we are now manipulating this cache with the optimistic response and previously it don't have it, the it never trigger it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optimistic response for shielded transfers
Plus, show more detailed information on transfer history: chain_id in case the name is missing on registry, and target in case of shielded transfers
closes #1553
Screen.Recording.2025-02-07.at.17.36.07.mov