Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support shielded tx with ledger #1562

Merged
merged 6 commits into from
Jan 30, 2025
Merged

feat: support shielded tx with ledger #1562

merged 6 commits into from
Jan 30, 2025

Conversation

mateuszjasiuk
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk commented Jan 16, 2025 •
edited
Loading

Support for ledger masp txs with disposable gas payer.

Testing:

  • signing txs with or without ledger and see if it works :D

@mateuszjasiuk mateuszjasiuk force-pushed the feat/shielded-transfers-using-disposable-gas-payer branch from 47862ab to 0cf0a7a Compare January 16, 2025 11:19
@mateuszjasiuk mateuszjasiuk changed the base branch from feat/shielded-transfers-using-ledger to feat/extension-ledger-masp-accounts January 16, 2025 11:21
@mateuszjasiuk mateuszjasiuk changed the title Feat/shielded transfers using disposable gas payer feat: support shielded tx with ledger Jan 16, 2025
@mateuszjasiuk mateuszjasiuk mentioned this pull request Jan 16, 2025
Closed
@mateuszjasiuk mateuszjasiuk force-pushed the feat/shielded-transfers-using-disposable-gas-payer branch from 0cf0a7a to b548323 Compare January 16, 2025 12:43
@jurevans jurevans mentioned this pull request Jan 21, 2025
Draft
@mateuszjasiuk mateuszjasiuk force-pushed the feat/extension-ledger-masp-accounts branch 2 times, most recently from ade8852 to dee92ad Compare January 21, 2025 11:20
Base automatically changed from feat/extension-ledger-masp-accounts to feat/ledger-masp-integration-branch January 21, 2025 11:56
@mateuszjasiuk mateuszjasiuk force-pushed the feat/shielded-transfers-using-disposable-gas-payer branch from b548323 to 61d99ce Compare January 21, 2025 12:47
@mateuszjasiuk mateuszjasiuk force-pushed the feat/ledger-masp-integration-branch branch from c02399f to af9a137 Compare January 27, 2025 12:09
@mateuszjasiuk mateuszjasiuk force-pushed the feat/shielded-transfers-using-disposable-gas-payer branch from 61d99ce to 3bfbb29 Compare January 27, 2025 13:44
@mateuszjasiuk mateuszjasiuk marked this pull request as ready for review January 27, 2025 13:45
@mateuszjasiuk mateuszjasiuk force-pushed the feat/shielded-transfers-using-disposable-gas-payer branch from 3bfbb29 to 1c6d586 Compare January 27, 2025 14:40
jurevans
jurevans approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Was able to successfully sign & submit each MASP transfer type!

@mateuszjasiuk mateuszjasiuk merged commit e8c86ce into feat/ledger-masp-integration-branch Jan 30, 2025
7 checks passed
@mateuszjasiuk mateuszjasiuk deleted the feat/shielded-transfers-using-disposable-gas-payer branch January 30, 2025 15:57
mateuszjasiuk added a commit that referenced this pull request Feb 10, 2025
@mateuszjasiuk
feat: support shielded tx with ledger (#1562)
d95dcbe 
* feat: support ledger masp tx wip

* feat: unshielding working

* chore: cleanup

* feat: ledger masp with disposable signer

* feat: disposable signer for shielded transfers using ledger

* feat: proper flow for ledger txs from masp source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurevans jurevans jurevans approved these changes

@euharrison euharrison Awaiting requested review from euharrison

@pedrorezende pedrorezende Awaiting requested review from pedrorezende

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszjasiuk @jurevans