feat/746 - Updates for Ledger HW (shielded keys) #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6430110 to
94667e1
Compare
6f8d9b0 to
05608ba
Compare
jurevans
commented
Jan 9, 2025
| @@ -20,7 +20,7 @@ type Props = { | |||
| status?: CompletionStatus; | |||
| statusInfo: string; | |||
| parentAccountStore?: AccountStore; | |||
| shieldedAccount?: DerivedAccount; | |||
| paymentAddress?: string; | |||
There was a problem hiding this comment.
was just simplifying here - we do not need to track the whole shielded account, only the payment address to display in confirmation
9f74c59 to
14cd8e6
Compare
14cd8e6 to
3ea76fe
Compare
3ea76fe to
c0308b4
Compare
278292b
into
feat/ledger-masp-integration-branch
7 checks passed
mateuszjasiuk
pushed a commit
that referenced
this pull request
Jan 27, 2025
* feat: bump to latest Ledger package * feat: begin hooking up shielded keys import * feat: split proof-gen and viewing key calls, fix paths * fix: fix tests * feat: stealing Mateusz code, show payment address in confirmation * feat: validate semver of installed app for Zip32 * feat: begin implementing import approval steps
mateuszjasiuk
pushed a commit
that referenced
this pull request
Feb 10, 2025
* feat: bump to latest Ledger package * feat: begin hooking up shielded keys import * feat: split proof-gen and viewing key calls, fix paths * fix: fix tests * feat: stealing Mateusz code, show payment address in confirmation * feat: validate semver of installed app for Zip32 * feat: begin implementing import approval steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #746
Also this implements a stepped process, so users can know what's happening on the ledger (now that there's 3 approvals instead of 1):
See #1458 from @mateuszjasiuk - We'll also need these changes.
@zondax/ledger-namadapackage (currently at2.0.0)getViewingKeyandgetProofGenerationKey(split upgetShieldedKeysso that we may turn these into steps, as they are separate approvals)xfvk)zvknam1)xfvk,akandnskTESTING
yarnon this branch to get updated packagesv2.0.2of Ledger app (via https://hub.zondax.ch/namada for now) NOTE This will require that you are on the latest firmware, so update if needed!DESIGNS
Approval steps
SCREENSHOTS
Version detection (NOTE:
2.0.0is the correct min-version, I just did this as a test since I am already upgraded to the latest Ledger app):