Skip to content

Commit

Permalink
ZTS: Add tests for creation time
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
  • Loading branch information
Ryan Moeller authored and Ryan Moeller committed Aug 5, 2021
1 parent 5b6da04 commit e2465c1
Show file tree
Hide file tree
Showing 10 changed files with 187 additions and 5 deletions.
1 change: 1 addition & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ AC_CONFIG_FILES([
tests/zfs-tests/tests/functional/cli_user/zpool_status/Makefile
tests/zfs-tests/tests/functional/compression/Makefile
tests/zfs-tests/tests/functional/cp_files/Makefile
tests/zfs-tests/tests/functional/crtime/Makefile
tests/zfs-tests/tests/functional/ctime/Makefile
tests/zfs-tests/tests/functional/deadman/Makefile
tests/zfs-tests/tests/functional/delegate/Makefile
Expand Down
4 changes: 4 additions & 0 deletions tests/runfiles/common.run
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,10 @@ tags = ['functional', 'compression']
tests = ['cp_files_001_pos']
tags = ['functional', 'cp_files']

[tests/functional/crtime]
tests = ['crtime_001_pos' ]
tags = ['functional', 'crtime']

[tests/functional/ctime]
tests = ['ctime_001_pos' ]
tags = ['functional', 'ctime']
Expand Down
7 changes: 7 additions & 0 deletions tests/test-runner/bin/zts-report.py.in
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ python_deps_reason = 'Python modules missing: python-cffi'
#
tmpfile_reason = 'Kernel O_TMPFILE support required'

#
# Some tests require the statx(2) system call on Linux which was first
# introduced in the 4.11 kernel.
#
statx_reason = 'Kernel statx(2) system call required on Linux'

#
# Some tests require that the NFS client and server utilities be installed.
#
Expand Down Expand Up @@ -193,6 +199,7 @@ elif sys.platform.startswith('linux'):
#
maybe = {
'chattr/setup': ['SKIP', exec_reason],
'crtime/crtime_001_pos': ['SKIP', statx_reason],
'cli_root/zdb/zdb_006_pos': ['FAIL', known_reason],
'cli_root/zfs_destroy/zfs_destroy_dev_removal_condense':
['FAIL', known_reason],
Expand Down
28 changes: 28 additions & 0 deletions tests/zfs-tests/include/libtest.shlib
Original file line number Diff line number Diff line change
Expand Up @@ -4048,6 +4048,34 @@ function stat_size #<path>
esac
}

function stat_ctime #<path>
{
typeset path=$1

case $(uname) in
FreeBSD)
stat -f %c "$path"
;;
*)
stat -c %Z "$path"
;;
esac
}

function stat_crtime #<path>
{
typeset path=$1

case $(uname) in
FreeBSD)
stat -f %B "$path"
;;
*)
stat -c %W "$path"
;;
esac
}

# Run a command as if it was being run in a TTY.
#
# Usage:
Expand Down
1 change: 1 addition & 0 deletions tests/zfs-tests/tests/functional/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ SUBDIRS = \
cli_user \
compression \
cp_files \
crtime \
ctime \
deadman \
delegate \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,7 @@ do
continue;
fi

if is_freebsd; then
filetime="$(stat -f "%c" $file)"
else
filetime="$(stat -c '%Z' $file)"
fi
filetime=$(stat_ctime $file)
if [[ "$filetime" != "$ctime" ]]; then
log_fail "Unexpected ctime for file $file ($filetime != $ctime)"
else
Expand Down
5 changes: 5 additions & 0 deletions tests/zfs-tests/tests/functional/crtime/Makefile.am
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pkgdatadir = $(datadir)/@PACKAGE@/zfs-tests/tests/functional/crtime
dist_pkgdata_SCRIPTS = \
cleanup.ksh \
setup.ksh \
crtime_001_pos.ksh
34 changes: 34 additions & 0 deletions tests/zfs-tests/tests/functional/crtime/cleanup.ksh
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
#!/bin/ksh -p
#
# CDDL HEADER START
#
# The contents of this file are subject to the terms of the
# Common Development and Distribution License (the "License").
# You may not use this file except in compliance with the License.
#
# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
# or http://www.opensolaris.org/os/licensing.
# See the License for the specific language governing permissions
# and limitations under the License.
#
# When distributing Covered Code, include this CDDL HEADER in each
# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
# If applicable, add the following below this CDDL HEADER, with the
# fields enclosed by brackets "[]" replaced with your own identifying
# information: Portions Copyright [yyyy] [name of copyright owner]
#
# CDDL HEADER END
#

#
# Copyright 2007 Sun Microsystems, Inc. All rights reserved.
# Use is subject to license terms.
#

#
# Copyright (c) 2013 by Delphix. All rights reserved.
#

. $STF_SUITE/include/libtest.shlib

default_cleanup
71 changes: 71 additions & 0 deletions tests/zfs-tests/tests/functional/crtime/crtime_001_pos.ksh
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
#!/bin/ksh -p
#
# CDDL HEADER START
#
# The contents of this file are subject to the terms of the
# Common Development and Distribution License (the "License").
# You may not use this file except in compliance with the License.
#
# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
# or http://www.opensolaris.org/os/licensing.
# See the License for the specific language governing permissions
# and limitations under the License.
#
# When distributing Covered Code, include this CDDL HEADER in each
# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
# If applicable, add the following below this CDDL HEADER, with the
# fields enclosed by brackets "[]" replaced with your own identifying
# information: Portions Copyright [yyyy] [name of copyright owner]
#
# CDDL HEADER END
#
# Portions Copyright 2021 iXsystems, Inc.
#

. $STF_SUITE/include/libtest.shlib

#
# DESCRIPTION:
#
# Verify crtime is functional with xattr=on|sa

verify_runnable "both"

#
# The statx system call was first added in the 4.11 Linux kernel. Prior to this
# change there was no mechanism to obtain birth time on Linux. Therefore, this
# test is expected to fail on older kernels and is skipped.
#
if is_linux; then
if [[ $(linux_version) -lt $(linux_version "4.11") ]]; then
log_unsupported "Requires statx(2) system call on Linux"
fi
typeset stat_version=$(stat --version | awk '{ print $NF; exit }')
if compare_version_gte "8.30" "${stat_version}"; then
log_unsupported "Requires coreutils stat(1) > 8.30 on Linux"
fi
fi

log_assert "Verify crtime is functional."

set -A args "sa" "on"
typeset TESTFILE=$TESTDIR/testfile

for arg in ${args[*]}; do
log_note "Testing with xattr set to $arg"
log_must zfs set xattr=$arg $TESTPOOL
rm -f $TESTFILE
log_must touch $TESTFILE
typeset -i crtime=$(stat_crtime $TESTFILE)
typeset -i ctime=$(stat_ctime $TESTFILE)
if (( crtime != ctime )); then
log_fail "Incorrect crtime ($crtime != $ctime)"
fi
log_must touch $TESTFILE
typeset -i crtime1=$(stat_crtime $TESTFILE)
if (( crtime1 != crtime )); then
log_fail "touch modified crtime ($crtime1 != $crtime)"
fi
done

log_pass "Verified crtime is functional."
35 changes: 35 additions & 0 deletions tests/zfs-tests/tests/functional/crtime/setup.ksh
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/bin/ksh -p
#
# CDDL HEADER START
#
# The contents of this file are subject to the terms of the
# Common Development and Distribution License (the "License").
# You may not use this file except in compliance with the License.
#
# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
# or http://www.opensolaris.org/os/licensing.
# See the License for the specific language governing permissions
# and limitations under the License.
#
# When distributing Covered Code, include this CDDL HEADER in each
# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
# If applicable, add the following below this CDDL HEADER, with the
# fields enclosed by brackets "[]" replaced with your own identifying
# information: Portions Copyright [yyyy] [name of copyright owner]
#
# CDDL HEADER END
#

#
# Copyright 2007 Sun Microsystems, Inc. All rights reserved.
# Use is subject to license terms.
#

#
# Copyright (c) 2013 by Delphix. All rights reserved.
#

. $STF_SUITE/include/libtest.shlib

DISK=${DISKS%% *}
default_setup $DISK

0 comments on commit e2465c1

Please sign in to comment.