Added MariaDB

ankane · Mar 11, 2024 · f149329 · f149329
1 parent 16a55b5
commit f149329
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -80,7 +80,7 @@ Postgres-specific checks:
 - [setting NOT NULL on an existing column](#setting-not-null-on-an-existing-column)
 - [adding a column with a default value](#adding-a-column-with-a-default-value)
 
-MySQL-specific checks:
+MySQL/MariaDB-specific checks:
 
 - [adding an AUTO_INCREMENT column](#adding-an-auto-increment-column) [unreleased]
 
@@ -674,7 +674,7 @@ Then [backfill the data](#backfilling-data).
 
 #### Bad
 
-In MySQL, adding an `AUTO_INCREMENT` column blocks writes while the entire table is rewritten.
+In MySQL and MariaDB, adding an `AUTO_INCREMENT` column blocks writes while the entire table is rewritten.
 
 ```ruby
 class AddIdToCitiesUsers < ActiveRecord::Migration[7.1]

diff --git a/lib/strong_migrations/checks.rb b/lib/strong_migrations/checks.rb
@@ -79,7 +79,7 @@ def check_add_column(*args)
         raise_error :add_column_generated_stored, rewrite_blocks: adapter.rewrite_blocks
       end
 
-      if type.to_s == "primary_key" && mysql?
+      if type.to_s == "primary_key" && (mysql? || mariadb?)
         raise_error :add_column_primary_key, rewrite_blocks: adapter.rewrite_blocks
       end
     end

diff --git a/test/add_column_test.rb b/test/add_column_test.rb
@@ -73,7 +73,7 @@ def test_generated_virtual
   end
 
   def test_primary_key
-    skip unless mysql?
+    skip unless mysql? || mariadb?
     assert_unsafe AddColumnPrimaryKey
   end
 end