-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to VS2017 /MSBuild15 / .NET Standard / .NET Core #261
Conversation
Fixes #262 when merged. |
Slowly moving towards completion. I spent some time redoing all the build scripts, but it now properly builds, tests, packs and publishes nugets via Appveyor CI. https://www.nuget.org/packages/UnitsNet/3.65.0-alpha1 |
Wow, now you put some effort into this! :) Would you mind pushing the current alpha version of the serialization package to nuget, because there's currently no version on nuget that works with dotnet core? |
I had some issues building, but just pushed some manual nugets out now. They are prerelease versions I must say, this whole vs2017 journey has not been entirely pleasant. It took a lot more time plow through than I'd like to admit, but I do like a lot of the concepts that |
Currently running into this issue: microsoft/vstest#445 (comment) Tests refuse to run when the output dir is changed using |
Sorry that I sort of "tricked" you into this effort. ;-) I naively assumed that it would be sufficient to remove a few lines in the If there's any specific task you need help with please let me know; unless it's fixing the code-gerenating/build/pack/sign scripts, since I don't know Powershell and don't want to learn it ATM. :) |
Hah, no worries :-) It would have to be done at some point anyway, and your effort really helped get over those initial roadblocks, so thanks for that! |
Yes, I'm using the alpha version including JsonNet serialization in a dotnetcore app, works like a charm. Thanks!! :) |
Cool! :-)
…On Thu, Jun 8, 2017 at 10:05 AM Michael Helmling ***@***.***> wrote:
Yes, I'm using the alpha version including JsonNet serialization in a
dotnetcore app, works like a charm. Thanks!! :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwFaAFTM7AXP5Ne-kzpyRzxL1HOpqRAks5sB6tjgaJpZM4NvBEi>
.
|
Fix an EOL issue in the tests by the way.
* dotnet CLI to build, test and pack nugets * msbuild for WindowsRuntimeComponent projects (dotnet not supported) * Xunit instead of Nunit
…ossible * Add NetStandard10.Signed * Add UnitsNet.Serialization.JsonNet.Signed * Remove Portable40 (replaced by netstandard) * Remove Net35 (merged into NetStandard10) * Move test projects into their own folders ('dotnet xunit' requires it) * Convert UnitsNet.Tests to .NET Core * Convert WindowsRuntimeComponent-Net45 to .NET Core (and rename to .ForTests)
From NUnit. Needed to transition to 'dotnet xunit', since 'dotnet test' is very limited right now and NUnit does not have a similar solution yet. Can always revert back, but there seems to be more push around xunit these days.
Squashed the intermediate alpha1-2 commits
Squashed alpha1-2 commits
Merged! Phew.. a lot of hurdles on the windows runtime component stuff, as well as nunit and xunit with the new Thanks a lot for putting in the effort here. Hopefully this is now fairly future proof and not too many things change when dotnet CLI 2.0 goes RTM. |
Thank you as well for finishing this! I can only hope that Microsoft's approach with .NET standard will help to simplify multi-target libraries in the future ... |
This PR resolves #255. See #257 for initial discussion.
TODO:
UnitsNet.WindowsRuntimeComponent
(notsure yet ifdotnet CLI compatible)UnitsNet.sln
can be removed or renamed toUnitsNet.WindowsRuntimeComponent.sln
if that is the only project that is not compatible with dotnet CLI.\Artifacts\Logs\<TestProjectName>.xml
files, currently blocked by NUnit support in dotnet CLI. XUnit seems to have found a workaround, so either wait for NUnit to do the same or switch to XUnit.