Add strong name signed core nuget #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type constants into JSON and test cases instead. Also avoids issue with friendly assemblies and strong name signing.
Only usage was Constants type, which is now deleted. Also it complicated the setup of strong naming on build server while not exposing any keys in repo, when having a friend assembly.
Found that the test incorrectly accessed internal members that circumvented the WinRT API surface. After test assembly no longer is a friend assembly, this forced us to properly deal with the incompatible test cases.
If specified and file exists, the solution will be built with strong name signing enabled. Typically only the build server will do this, which has the private key installed.
b0b49d1 to
63350d0
Compare
* Add build-signed.msbuild and bat file * Rename all.msbuild to build-all.msbuild for consistency * Rewrite msbuild files to Clean, Build and Rebuild targets * Update build scripts * build.bat takes optional .pfx key file for signing Notes: * Moves binaries to Src-signed and Src-unsigned dirs after each build * Only builds signed binaries after tests have passed * If no key file is specified, signed binaries are skipped * Only build server has .pfx key file
Point to Src-unsigned dir
5af5b48 to
4089e95
Compare
|
Heads up on strong name signing key now being published and also changed to a new key: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for strong name signing as discussed in #135.