Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SpecificFuelConsumption.GramPerKiloNewtonSecond to GramPerKilonewtonSecond #1491

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Rename SpecificFuelConsumption.GramPerKiloNewtonSecond to GramPerKilonewtonSecond #1491

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e623a1d
Rename SpecificFuelConsumption.GramPerKiloNewtonSecond to GramPerKilo…
lipchev Jan 3, 2025
730eab1
manually renaming the SpecificFuelConsumption units in the UnitEnumVa…
lipchev Jan 3, 2025
57253c9
Merge remote-tracking branch 'upstrteam/release/v6' into rename-sfc-k…
lipchev Jan 7, 2025
98262af
fix the Convert_GetTypeCode_Returns_Object using the old spelling
lipchev Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Common/UnitDefinitions/SpecificFuelConsumption.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"Name": "SpecificFuelConsumption",
"BaseUnit": "GramPerKiloNewtonSecond",
"BaseUnit": "GramPerKilonewtonSecond",
"XmlDocSummary": "SFC is the fuel efficiency of an engine design with respect to thrust output",
"XmlDocRemarks": "https://en.wikipedia.org/wiki/Thrust-specific_fuel_consumption",
"BaseDimensions": {
Expand Down Expand Up @@ -33,8 +33,8 @@
]
},
{
"SingularName": "GramPerKiloNewtonSecond",
"PluralName": "GramsPerKiloNewtonSecond",
"SingularName": "GramPerKilonewtonSecond",
"PluralName": "GramsPerKilonewtonSecond",
"BaseUnits": {
"L": "Meter",
"T": "Second"
Expand Down
4 changes: 3 additions & 1 deletion Common/UnitEnumValues.g.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,9 @@
"GramPerKiloNewtonSecond": 1,
"KilogramPerKilogramForceHour": 2,
"KilogramPerKiloNewtonSecond": 3,
"PoundMassPerPoundForceHour": 4
"PoundMassPerPoundForceHour": 4,
"GramPerKilonewtonSecond": 11,
"KilogramPerKilonewtonSecond": 6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

This maybe a little hack-y, but I think that if we changed these by hand (to the old values) - I think they would stick.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I suggest we do the same here, match the old values.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 730eab1

},
"SpecificVolume": {
"CubicFootPerPound": 1,
Expand Down
26 changes: 13 additions & 13 deletions UnitsNet.NanoFramework/GeneratedCode/Quantities/SpecificFuelConsumption.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions UnitsNet.NanoFramework/GeneratedCode/Units/SpecificFuelConsumptionUnit.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...t.NumberExtensions.Tests/GeneratedCode/NumberToSpecificFuelConsumptionExtensionsTest.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions UnitsNet.NumberExtensions/GeneratedCode/NumberToSpecificFuelConsumptionExtensions.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions UnitsNet.Tests/CustomCode/SpecificFuelConsumptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ public class SpecificFuelConsumptionTests : SpecificFuelConsumptionTestsBase
// Override properties in base class here
protected override bool SupportsSIUnitSystem => false;

protected override double GramsPerKiloNewtonSecondInOneGramPerKiloNewtonSecond => 1;
protected override double GramsPerKilonewtonSecondInOneGramPerKilonewtonSecond => 1;

protected override double KilogramsPerKiloNewtonSecondInOneGramPerKiloNewtonSecond => 1e-3;
protected override double KilogramsPerKilonewtonSecondInOneGramPerKilonewtonSecond => 1e-3;

protected override double PoundsMassPerPoundForceHourInOneGramPerKiloNewtonSecond => 0.03529827;
protected override double PoundsMassPerPoundForceHourInOneGramPerKilonewtonSecond => 0.03529827;

protected override double KilogramsPerKilogramForceHourInOneGramPerKiloNewtonSecond => 0.03529827;
protected override double KilogramsPerKilogramForceHourInOneGramPerKilonewtonSecond => 0.03529827;
}
}
Loading