Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "🔥Remove static Default getters, obsoleted by UnitsNetSetup" #1480

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Revert "🔥Remove static Default getters, obsoleted by UnitsNetSetup" #1480

merged 1 commit into from
Dec 29, 2024

Conversation

angularsen
Copy link
Owner

@angularsen angularsen commented Dec 29, 2024 •
edited
Loading

Reverts #1475

This reverts commit a3c32b6.

  • Add back default getters
  • Remove obsolete message, rewrite xmldoc a bit

@codecov Codecov
Copy link

codecov bot commented Dec 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86%. Comparing base (3f1456d) to head (b0180c6).
Report is 1 commits behind head on release/v6.

Files with missing lines Patch % Lines
UnitsNet/CustomCode/QuantityParser.cs 0% 1 Missing ⚠️
UnitsNet/CustomCode/UnitAbbreviationsCache.cs 0% 1 Missing ⚠️
UnitsNet/CustomCode/UnitParser.cs 0% 1 Missing ⚠️
UnitsNet/UnitConverter.cs 0% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           release/v6   #1480   +/-   ##
==========================================
- Coverage          86%     86%   -1%     
==========================================
  Files             298     298           
  Lines           30515   30519    +4     
==========================================
  Hits            26405   26405           
- Misses           4110    4114    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angularsen
Revert "🔥Remove static Default getters, obsoleted by UnitsNetSetup (#…
b0180c6 
…1475)"

This reverts commit a3c32b6.

- Add back default getters
- Remove obsolete message, rewrite xmldoc a bit
@angularsen angularsen force-pushed the revert-1475-agl/rem-default branch from 1ee3f76 to b0180c6 Compare December 29, 2024 01:33
@angularsen angularsen marked this pull request as ready for review December 29, 2024 01:34
@angularsen angularsen merged commit 804cf7e into release/v6 Dec 29, 2024
1 check was pending
@angularsen angularsen deleted the revert-1475-agl/rem-default branch December 29, 2024 01:35
@angularsen angularsen mentioned this pull request Dec 29, 2024
Merged
angularsen added a commit that referenced this pull request Dec 29, 2024
@angularsen
Un-obsolete static Default getters (#1481)
bb1420e 
Per [discussion
](#1475 (comment))
in v6, we no longer want to remove these.

Already reverted in v6 with #1480
This was referenced Dec 29, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@angularsen