tslint no-string-literal check is wrong

[evmar]

[16:19:04] [gulp-tslint] error (no-string-literal) main.ts[43, 18]: object access via string literals is disallowed

However, the object in question is from minimist and defined as

        export interface ParsedArgs {
            [arg: string]: any;
            _: string[];
        }

so I should be able to index into it with a string.

What's the fix -- fix tslint or fix our settings?

[mprobst]

I think this rule does not do what I hoped it'd do. It just checks if whatever is in the brackets could in theory be a valid identifier on the object, but not whether the object allows it :-(

@alexeagle do you know if tslint does or will support type based checks?

[alexeagle]

palantir/tslint#680

They can't run the typechecker because they only do file-by-file analysis
without typechecking. This is motivating the design of something they
haven't shown me called tsvet, as well as my thing

On Mon, Apr 11, 2016 at 3:38 PM Martin Probst notifications@github.com
wrote:

I think this rule does not do what I hoped it'd do. It just checks if
whatever is in the brackets could in theory be a valid identifier on the
object, but not whether the object allows it :-(

@alexeagle https://github.com/alexeagle do you know if tslint does or
will support type based checks?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#126 (comment)