chore(release): version bump and update changelog #3942
Conversation
| See the [selenium-webdriver changelog](https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md). Some of the breaking change highlights are summarized below: | ||
|
|
||
| - Minimum node version 6.9.x for selenium-webdriver dependency. | ||
| - Jasmine typescript users will need to include the `@types/jasmine`. This |
| This version includes big changes around upgrading to selenium-webdriver 3.0.x. | ||
| See the [selenium-webdriver changelog](https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md). Some of the breaking change highlights are summarized below: | ||
|
|
||
| - Minimum node version 6.9.x for selenium-webdriver dependency. |
There was a problem hiding this comment.
Just "minimum supported node version is now 6.9.x"
| - Methods removed: `WebDriver.prototype.isElementPresent`, | ||
| `WebElement.prototype.getRawId`, `WebElement.prototype.getInnerHtml`, and | ||
| `WebElement.prototype.getOuterHtml`. | ||
| - Selenium-webdriver `ErrorCodes` have been deprecated. |
| ## Features | ||
|
|
||
| - ([ec93c4a](https://github.com/angular/protractor/commit/ec93c4ab882991410ad9d3f52d87c0f5ec947641)) | ||
| chore(cli): **breaking change** throw errors on unknown flags (#3921) |
There was a problem hiding this comment.
Maybe clarify 'unknown CLI flags'?
| For the 5.0.0 release, we are still using the selenium standalone server 2.53.1 | ||
| and recommend using Firefox 47. | ||
|
|
||
| ## Features |
There was a problem hiding this comment.
We should have a ## Breaking Changes section like we've done in the past. You can include everything that's a breaking change from features/deps here (and not include it in the other categories, or include just the title, I don't care)
There was a problem hiding this comment.
Some of the stuff from the quick list above should probably be formalized and moved to the breaking changes section.
|
|
||
| closes #1742 | ||
| - ([604fdbf](https://github.com/angular/protractor/commit/604fdbf064cc2785a2e745747beeaeb45d27f8ed)) | ||
| cleanup(config): **breaking change** Remove redundant sauceProxy config (#3868) |
There was a problem hiding this comment.
Why is this a breaking change? The commit message doesn't list it as such.
There was a problem hiding this comment.
It removes the sauceProxy config field, and uses webDriverProxy when creating the SauceLabs client.
There was a problem hiding this comment.
added additional note about webDriverProxy
| chore(dependency): switch to webdriver-manager 11.1.0 and remove | ||
| `--versions.chrome 2.26` from circle.yml (#3865) | ||
| - ([397bf65](https://github.com/angular/protractor/commit/397bf65e088b640cf3612f9da678180f49939b84)) | ||
| deps(update): move @types/jasmine to devDependencies (#3795) |
There was a problem hiding this comment.
This one should get listed as a breaking change, and have the solution (add @types to your deps) clearly listed.
| - Removed method `WebElement.prototype.getRawId` | ||
| - Removed `getInnerHtml` and `getOutterHtml` | ||
|
|
||
| - Dependency required for upgrade: use `jasminewd2@0.1.0-beta.0`. |
|
|
||
| - Updated debug commons for breakpoint updated to selenium-webdriver | ||
| `lib/http` line 432. | ||
| - Debugger currently does not work. So `elementExplorer` for this current |
There was a problem hiding this comment.
removed debugger / disabled tests comment
| - ([a3e8b43](https://github.com/angular/protractor/commit/a3e8b4319d3e8b049e55e5c3c64a7fdb5a132ddf)) | ||
| deps(selenium-webdriver): upgrade to selenium 3 (#3781) | ||
|
|
||
| Note: with the upgrade, there might have breaking changes. Please see the |
There was a problem hiding this comment.
'there might have been'. Might be redundant since we do list methods that got removed.
27b4f22 to
35e4d9f
Compare
|
|
||
| - Minimum node version is now 6.9.x. | ||
| - When testing with Firefox 47, use the capability option `marionette: false` | ||
| to use the legacy Firefox driver. |
There was a problem hiding this comment.
Let's add an explicit:
After:
capabilities: {
browserName: 'firefox',
marionette: false
}
| to use the legacy Firefox driver. | ||
| - We moved `@types/jasmine` to a devDependency. This means that Jasmine | ||
| TypeScript users will need to include the `@types/jasmine` as a project | ||
| dependency. This is to avoid conflicts for users that prefer mocha typings. |
There was a problem hiding this comment.
After:
dependencies: {
'@types/jasmine': '^2.4.0'
}
| dependency. This is to avoid conflicts for users that prefer mocha typings. | ||
| - Selenium-webdriver methods removed: `WebDriver.prototype.isElementPresent`, | ||
| `WebElement.prototype.getRawId`, `WebElement.prototype.getInnerHtml`, and | ||
| `WebElement.prototype.getOuterHtml`. |
There was a problem hiding this comment.
Before:
let i = element(locator).getInnerHtml();After:
let i = browser..executeScript("return arguments[0].innerHTML;", element(locator));| default to using all app hooks, and ng1 apps now check several places, notably | ||
| the element the app bootstraps to. | ||
| - `sauceProxy` configuration field has been removed. Use `webDriverProxy` | ||
| instead. |
|
LGTM. |
No description provided.