Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

build: support NodeJS v12 and v14. release script updates. #11892

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[x] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • NodeJS v12 and v14 are not supported as gulp tasks fail due to ReferenceError: primordials is not defined in node
  • the release script doesn't update package-lock.json which causes future PRs to awkwardly need to include this change
  • none of the docs site snapshots or releases are tagged
  • the version number in the commit message and the tags don't match

Issue Number:
Relates to #11844

What is the new behavior?

  • add support for NodeJS v12 and v14
  • release script updates version in package-lock.json
  • remove unused release.sh script
  • start tagging docs snapshots and releases
  • use more consistent release commit messages and git commands
  • improve release script log messages

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This leverages the approach described in https://stackoverflow.com/a/58394828/633107.

- release script updates version in `package-lock.json`
- remove unused `release.sh` script
- start tagging docs snapshots and releases
- use more consistent release commit messages and git commands
- improve release script log messages

Relates to #11844
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 23, 2020
@Splaktar Splaktar self-assigned this Apr 23, 2020
@Splaktar Splaktar added this to the 1.1.22 milestone Apr 23, 2020
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. type: build labels Apr 23, 2020
@Splaktar Splaktar requested a review from jelbourn April 23, 2020 04:21
@Splaktar
Copy link
Member Author

@oliversalzburg you should be pretty happy about this change. I'd love to get your feedback on it.

@Splaktar Splaktar added needs: review This PR is waiting on review from the team pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Apr 23, 2020
@oliversalzburg
Copy link
Contributor

That looks fantastic! I wish I had known about this before I rewrote our own toolchain to use gulp@4...

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: lgtm This PR has been approved by the reviewer and removed needs: review This PR is waiting on review from the team labels Apr 23, 2020
@Splaktar Splaktar merged commit 67b06f4 into master Apr 23, 2020
@Splaktar Splaktar deleted the nodejs-12-14-support branch April 23, 2020 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants