Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple): resolve host binding issues #30570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/material/chips/chip-listbox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ export const MAT_CHIP_LISTBOX_CONTROL_VALUE_ACCESSOR: any = {
'class': 'mdc-evolution-chip-set mat-mdc-chip-listbox',
'[attr.role]': 'role',
'[tabIndex]': '(disabled || empty) ? -1 : tabIndex',
// TODO: replace this binding with use of AriaDescriber
'[attr.aria-describedby]': '_ariaDescribedby || null',
'[attr.aria-required]': 'role ? required : null',
'[attr.aria-disabled]': 'disabled.toString()',
'[attr.aria-multiselectable]': 'multiple',
Expand Down
2 changes: 1 addition & 1 deletion src/material/chips/chip-row.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export interface MatChipEditedEvent extends MatChipEvent {
'[attr.aria-label]': 'null',
'[attr.aria-description]': 'null',
'[attr.role]': 'role',
'(focus)': '_handleFocus($event)',
'(focus)': '_handleFocus()',
'(dblclick)': '_handleDoubleclick($event)',
},
providers: [
Expand Down
2 changes: 1 addition & 1 deletion src/material/list/list-option.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export interface SelectionList extends MatListBase {
imports: [NgTemplateOutlet, CdkObserveContent],
})
export class MatListOption extends MatListItemBase implements ListOption, OnInit, OnDestroy {
private _selectionList = inject<SelectionList>(SELECTION_LIST);
protected _selectionList = inject<SelectionList>(SELECTION_LIST);
private _changeDetectorRef = inject(ChangeDetectorRef);

@ContentChildren(MatListItemLine, {descendants: true}) _lines: QueryList<MatListItemLine>;
Expand Down
2 changes: 1 addition & 1 deletion src/material/sort/sort-header.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ interface MatSortHeaderColumnDef {
'class': 'mat-sort-header',
'(click)': '_toggleOnInteraction()',
'(keydown)': '_handleKeydown($event)',
'(mouseleave)': '_recentlyCleared.set(false)',
'(mouseleave)': '_recentlyCleared.set(null)',
'[attr.aria-sort]': '_getAriaSortAttribute()',
'[class.mat-sort-header-disabled]': '_isDisabled()',
},
Expand Down
2 changes: 2 additions & 0 deletions tools/public_api_guard/material/list.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ export class MatListOption extends MatListItemBase implements ListOption, OnInit
get selected(): boolean;
set selected(value: BooleanInput);
readonly selectedChange: EventEmitter<boolean>;
// (undocumented)
protected _selectionList: SelectionList;
_setSelected(selected: boolean): boolean;
_setTabindex(value: number): void;
// (undocumented)
Expand Down
Loading