Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/button): incorrect outlined focus overlay shape when border radius is customized #30513

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix(material/button): incorrect outlined focus overlay shape when border radius is customized #30513

merged 1 commit into from
Feb 24, 2025
+2 −11

Conversation

crisbeto
Copy link
Member

Fixes that the focus overlay on outlined buttons wasn't covering the outlined button fully when its border radius is customized.

Fixes #30484.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 18, 2025
@crisbeto crisbeto requested a review from a team as a code owner February 18, 2025 11:19
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team February 18, 2025 11:19
@crisbeto crisbeto force-pushed the 30484/button-custom-radius branch from ff41aff to 8ac381a Compare February 19, 2025 13:30
@crisbeto crisbeto removed the request for review from wagnermaciel February 21, 2025 08:27
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 21, 2025
@crisbeto crisbeto force-pushed the 30484/button-custom-radius branch from 8ac381a to 986ab31 Compare February 24, 2025 13:43
@crisbeto
fix(material/button): incorrect outlined focus overlay shape when bor…
9701763 
…der radius is customized

Fixes that the focus overlay on outlined buttons wasn't covering the outlined button fully when its border radius is customized.

Fixes angular#30484.
@crisbeto crisbeto force-pushed the 30484/button-custom-radius branch from 986ab31 to 9701763 Compare February 24, 2025 13:44
@crisbeto crisbeto merged commit fea07a7 into angular:main Feb 24, 2025
20 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.1.x, 19.2.x

crisbeto added a commit that referenced this pull request Feb 24, 2025
@crisbeto
fix(material/button): incorrect outlined focus overlay shape when bor…
f9c036c 
…der radius is customized (#30513)

Fixes that the focus overlay on outlined buttons wasn't covering the outlined button fully when its border radius is customized.

Fixes #30484.

(cherry picked from commit fea07a7)
crisbeto added a commit that referenced this pull request Feb 24, 2025
@crisbeto
fix(material/button): incorrect outlined focus overlay shape when bor…
d01e16d 
…der radius is customized (#30513)

Fixes that the focus overlay on outlined buttons wasn't covering the outlined button fully when its border radius is customized.

Fixes #30484.

(cherry picked from commit fea07a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/button target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
3 participants
@crisbeto @mmalerba @andrewseguin