Implement new map marker clusterer #29885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0619bc3 to
db740bd
Compare
d4f8440 to
1653075
Compare
|
Deployed dev-app for a0742c9 to: https://ng-dev-previews-comp--pr-angular-components-29885-dev-ufuii8oi.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
This was referenced Oct 17, 2024
amysorto
reviewed
Oct 17, 2024
src/google-maps/deprecated-map-marker-clusterer/deprecated-map-marker-clusterer.spec.ts
Show resolved
Hide resolved
Deprecates the existing `MapMarkerClusterer`, because it's based on a deprecated library that doesn't support advanced markers. A new clusterer component will be introduced that supports both regular markers and advanced ones, and is based on the current marker library. BREAKING CHANGE: * The new @googlemaps/markerclusterer API should be imported instead of the old one. Read more at: https://github.com/googlemaps/js-markerclusterer * The `MapMarkerClusterer` class has been renamed to `DeprecatedMapMarkerClusterer`. * The `map-marker-clusterer` selector has been changed to `deprecated-map-marker-clusterer`.
andrewseguin
approved these changes
Oct 17, 2024
| @Component({ | ||
| selector: 'google-map-demo', | ||
| templateUrl: 'google-map-demo.html', | ||
| standalone: true, |
There was a problem hiding this comment.
Since this will be the default when released, we can remove this line from the example
Adds a new `MapMarkerClusterer` component that is based on the most up-to-date clustering library, and supports both regular and advanced markers. Fixes angular#23695.
Since the clusterer's class and tag were renamed, we need to migrated existing users to the new name.
1653075 to
a0742c9
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The history of clustering in Google Maps is complicated, but the result is that our current
map-marker-clusterercomponent is based on top of an unmaintained API. We haven't been able to switch to the new one without breaking changes, because it doesn't offer the same set of features as the old one. Furthermore, the current clusterer only supports theMarkerclass which is deprecated, but not theAdvancedMarkerwhich is the recommended class to use for markers, whereas the new API supports both kinds of markers. These changes attempt to cover both existing users and users who want to use the new API by:map-marker-clusterertodeprecated-map-marker-clusterer.map-marker-clustererbased on top of the new API.ng updateschematic to rename existing usages.Fixes #23695.