fix(material/dialog) Use align as @Input() in MatDialogActions
#24178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479
…of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental
align as @Input() in dialog-actions directivealign as @Input() in dialog-actions directive
align as @Input() in dialog-actions directivealign as @Input() in MatDialogActions
|
Not sure why I get a Build error in circleci. I don't know what the Orb eddiewebb/queue is or why it isn't loaded on my branch. @crisbeto |
|
Me neither, I guess CircleCI is just being weird 🙁. This is a shot in the dark, but we could try squashing all the commits (currently it's only one) and recreating the PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're relying on css selectors
[align='center']and[align='end']for aligning action buttons in the dialog. Relying on a non-standard attribute causes some issues, such as no self-documentation, no type checkings, more annoying data-binding syntax and errors from IDEs and text editors (notably, VS Code marks the align-attribute as red).This is a continuation from this PR that failed to trigger CircleCI workflows, here
Fixes #18479