Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(material-experimental/mdc-select): remove dependency on @material/select #24148

Merged
merged 1 commit into from
Jan 7, 2022
Merged

refactor(material-experimental/mdc-select): remove dependency on @material/select #24148

merged 1 commit into from
Jan 7, 2022

Conversation

crisbeto
Copy link
Member

Cleans up the MDC-based select's theme by removing the dependency on @material/select and the variable overrides since we weren't including any of MDC's mixins.

@crisbeto
refactor(material-experimental/mdc-select): remove dependency on @mat…
39ad0c8 
…erial/select

Cleans up the MDC-based select's theme by removing the dependency on `@material/select` and the variable overrides since we weren't including any of MDC's mixins.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 31, 2021
@crisbeto crisbeto requested a review from devversion December 31, 2021 08:33
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 6, 2022
@wagnermaciel wagnermaciel merged commit faf4b16 into angular:master Jan 7, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 7, 2022
@crisbeto @wagnermaciel
refactor(material-experimental/mdc-select): remove dependency on @mat…
9b96999 
…erial/select (#24148)

Cleans up the MDC-based select's theme by removing the dependency on `@material/select` and the variable overrides since we weren't including any of MDC's mixins.

(cherry picked from commit faf4b16)
zarend pushed a commit to zarend/components that referenced this pull request Jan 7, 2022
@crisbeto @zarend
refactor(material-experimental/mdc-select): remove dependency on @mat…
44c1361 
…erial/select (angular#24148)

Cleans up the MDC-based select's theme by removing the dependency on `@material/select` and the variable overrides since we weren't including any of MDC's mixins.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @wagnermaciel