Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/chips): Make MatChipInputEvent.chipInput required. #23692

Merged
merged 1 commit into from
Feb 4, 2022
Merged

fix(material/chips): Make MatChipInputEvent.chipInput required. #23692

merged 1 commit into from
Feb 4, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 5, 2021

BREAKING CHANGE: MatChipInputEvent.chipInput is now a required property.

@mmalerba
fix(material/chips): Make MatChipInputEvent.chipInput required.
1212bc7 
BREAKING CHANGE: `MatChipInputEvent.chipInput` is now a required property.
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Oct 5, 2021
@mmalerba mmalerba requested a review from crisbeto October 5, 2021 22:16
@mmalerba mmalerba requested review from jelbourn and a team as code owners October 5, 2021 22:16
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2021
crisbeto
crisbeto approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 6, 2021
@wagnermaciel
Copy link
Contributor

@mmalerba When I try merging this, I get an error that I'm not sure how to resolve

Unable to merge pull request. The "master" branch will be released as a minor version.

@mmalerba
Copy link
Contributor Author

@wagnermaciel This PR missed the cut-off for v13, the error means that we can't merge it until its time to merge breaking changes for v14

@mmalerba mmalerba added this to the 14.0.0 milestone Oct 25, 2021
@mmalerba mmalerba added merge safe and removed action: merge The PR is ready for merge by the caretaker labels Oct 25, 2021
@mmalerba
Copy link
Contributor Author

Note: this PR is merge safe as there is an existing copybara transform that makes this property required in google3 already.

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 3, 2022
@mmalerba mmalerba merged commit d67dad6 into angular:master Feb 4, 2022
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
@mmalerba @amysorto
fix(material/chips): Make MatChipInputEvent.chipInput required. (an…
f3933f1 
…gular#23692)

BREAKING CHANGE: `MatChipInputEvent.chipInput` is now a required property.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
14.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mmalerba @wagnermaciel @crisbeto @devversion @googlebot @andrewseguin