feat(cdk/focus-trap) Add ConfigurableFocusTrap tab-wrapping strategies #18282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5445642 to
3fb2866
Compare
This commit adds a new required strategy parameter to ConfigurableFocusTrap that dictates how it wraps tab focus, and two implementations of the new strategy. TabStopFocusTrapWrapStrategy has the same behavior as legacy FocusTrap. It adds hidden tab stops that redirect focus before and after the FocusTrap elements. TabListenerFocusTrapWrapStrategy caches the first and last element in the ConfigurableFocusTrap. It intercepts tab/shift-tab on these elements in order to wrap tab. It updates the cache when the FocusTrap DOM subtree has a tab-relevant change. For now, TabStopFocusTrapWrapStrategy is the default strategy in ConfigurableFocusTrapFactory, to simplify migration.
3fb2866 to
050308d
Compare
|
Closing because Axe 3.5.0 will downgrade aria-hidden-focus errors from “Severe” to “Needs Review” when a modal dialog (a dialog element, an element with aria-modal=”true”, or an element with role=”dialog”) is open on the page. This eliminates the primary impetus for removing the hidden tab stops. Axe PR: dequelabs/axe-core#1995 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new required strategy parameter to
ConfigurableFocusTrapthat dictates how it wraps tab, and two implementations of the new strategy.TabStopFocusTrapWrapStrategyhas the same behavior as legacy FocusTrap. It adds hidden tab stops that redirect focus before and after the FocusTrap elements.TabListenerFocusTrapWrapStrategycaches the first and last element inthe
ConfigurableFocusTrap. It intercepts tab/shift-tab on these elementsin order to wrap tab. It updates the cache when the FocusTrap DOM subtree
has a tab-relevant change.
For now,
TabStopFocusTrapWrapStrategyis the default strategy inConfigurableFocusTrapFactory, to simplify migration.