Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mat-menu/cdk-overlay): mat-menu items are clipped when content height grows after menu is opened. #21456

Closed
DaxChen opened this issue Dec 28, 2020 · 1 comment · Fixed by #21457
Closed

bug(mat-menu/cdk-overlay): mat-menu items are clipped when content height grows after menu is opened. #21456

DaxChen opened this issue Dec 28, 2020 · 1 comment · Fixed by #21457
Assignees
@crisbeto
Labels
area: material/menu P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@DaxChen
Copy link

DaxChen commented Dec 28, 2020

Reproduction

https://stackblitz.com/edit/angular-sfz2cr

Steps to reproduce:

  1. scroll the inner pink box to make the menu open downwards, but the opened menu just touches the bottom, like this: image
  2. The bug also happens on the opposite direction, when opening the menu upwards and the menu top touches the viewport top, like this: Screen Shot 2020-12-28 at 12 09 36 AM
  3. after 1 second, 20 new items will be added to the menu to make the menu longer.
  4. notice the menu is clipped and not all items are visible.

This only happens when the menu trigger is in a scrollable area.

Expected Behavior

The menu should be able to scroll and see all items.

Actual Behavior

the menu is clipped

Environment

  • Angular: 11.0.6
  • CDK/Material: 11.0.3
  • Browser(s): Version 87.0.4280.88 (Official Build) (x86_64)
  • Operating System (e.g. Windows, macOS, Ubuntu): macOS 10.15.7
@DaxChen DaxChen added the needs triage This issue needs to be triaged by the team label Dec 28, 2020
@crisbeto crisbeto self-assigned this Dec 28, 2020
@crisbeto crisbeto added area: material/menu has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Dec 28, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 28, 2020
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
57df72f 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
@crisbeto crisbeto mentioned this issue Dec 28, 2020
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 7, 2021
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
c02a6d6 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 3, 2021
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
bcc79b0 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
mmalerba pushed a commit to crisbeto/material2 that referenced this issue Jul 27, 2021
@crisbeto @mmalerba
fix(material/menu): adjust overlay size when amount of items changes
11be78f 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 3, 2022
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
fb6d88f 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 31, 2022
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
d85d950 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 31, 2022
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
f119525 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 31, 2022
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
2e83530 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 1, 2022
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
0c8a681 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 1, 2022
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes
0c8bd05 
Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
andrewseguin pushed a commit that referenced this issue Feb 1, 2022
@crisbeto @andrewseguin
fix(material/menu): adjust overlay size when amount of items changes (#…
d7fe423 
…21457)

Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes #21456.

(cherry picked from commit a74d92e)
andrewseguin pushed a commit that referenced this issue Feb 1, 2022
@crisbeto
fix(material/menu): adjust overlay size when amount of items changes (#…
a74d92e 
…21457)

Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes #21456.
PooSham added a commit to PooSham/Angular-Material-Components that referenced this issue Feb 2, 2022
@PooSham
fix(material/dialog): Squashed commit of the following:
26fabcd 
commit 261cb7c
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:26:03 2022 +0100

    fix(material/dialog): Fix mdc action align test

commit b060272
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:10:12 2022 +0100

    fix(material/dialog): update golden api for dialog

commit 69491e1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 17:50:37 2022 +0100

    fix(material/dialog): fix mismatching test names between mdc and non-mdc

commit b4a9cb3
Author: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date:   Tue Feb 1 17:09:37 2022 +0100

    fixup! fix(material/dialog): Use align as @input() in MatDialogActions

    ds

commit d7a9cbb
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:27:13 2022 +0100

    fix(material/dialog): Use align as @input() in MatDialogActions

    Squashed commit of the following:

    commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
    Merge: 3276432 3a98da8
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 31 19:24:24 2022 +0100

        Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2

    commit 3276432
    Merge: 815cf8f 1f40b7d
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Mon Jan 31 18:54:42 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2

    commit 815cf8f
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:23:12 2022 +0100

        Use directive binding in mdc-dialog demo for align

    commit 77fca70
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:20:43 2022 +0100

        Change actionsAlignment type in dialog demo

    commit c87c4aa
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 00:21:57 2022 +0100

        Revert weird changes to dialog.spec.ts

    commit d6deb45
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:30:24 2022 +0100

        Use 'start' as default instead of undefined for align attribute in dialog actions

    commit 8d367c1
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:05:54 2022 +0100

        Update comments in dialog.scss for more clarity

    commit 9d2ac16
    Merge: 54d0a60 3de4ab8
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 22:33:13 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479

    commit 54d0a60
    Merge: 462d407 c79e1d1
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:30:29 2022 +0100

        Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479

    commit c79e1d1
    Merge: 462d407 03485cd
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:23:17 2022 +0100

        Merge branch 'master' of https://github.com/angular/components into angular-master

    commit 462d407
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:18:08 2020 +0100

        fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes angular#18479 for material-experimental

    commit c101f7f
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:15:01 2020 +0100

        fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes angular#18479

commit a74d92e
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 16:43:35 2022 +0100

    fix(material/menu): adjust overlay size when amount of items changes (angular#21457)

    Currently we lock the menu into a position after it is opened so that it doesn't jump
    around when the user scrolls, but this means that if the amount of items changes,
    it might not be the optimal position anymore.

    These changes add some code to re-calculate the position if the amount of items changes.

    Fixes angular#21456.

commit f201634
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 13:22:16 2022 +0100

    build: fix rules_sass error (angular#24331)

    Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.
wagnermaciel pushed a commit that referenced this issue Feb 11, 2022
@PooSham @devversion
fix(material/dialog): Use align as @Input() in MatDialogActions (…
599d1b4 
…#24328)

* fix(material/dialog): Use align as @input() in MatDialogActions

Squashed commit of the following:

commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
Merge: 3276432 3a98da8
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:24:24 2022 +0100

    Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2

commit 3276432
Merge: 815cf8f 1f40b7d
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Mon Jan 31 18:54:42 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2

commit 815cf8f
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:23:12 2022 +0100

    Use directive binding in mdc-dialog demo for align

commit 77fca70
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:20:43 2022 +0100

    Change actionsAlignment type in dialog demo

commit c87c4aa
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 00:21:57 2022 +0100

    Revert weird changes to dialog.spec.ts

commit d6deb45
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:30:24 2022 +0100

    Use 'start' as default instead of undefined for align attribute in dialog actions

commit 8d367c1
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:05:54 2022 +0100

    Update comments in dialog.scss for more clarity

commit 9d2ac16
Merge: 54d0a60 3de4ab8
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 22:33:13 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479

commit 54d0a60
Merge: 462d407 c79e1d1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:30:29 2022 +0100

    Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479

commit c79e1d1
Merge: 462d407 03485cd
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:23:17 2022 +0100

    Merge branch 'master' of https://github.com/angular/components into angular-master

commit 462d407
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:18:08 2020 +0100

    fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes #18479 for material-experimental

commit c101f7f
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:15:01 2020 +0100

    fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes #18479

* fix(material/dialog): Use align as @input() in MatDialogActions

Squashed commit of the following:

commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
Merge: 3276432 3a98da8
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:24:24 2022 +0100

    Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2

commit 3276432
Merge: 815cf8f 1f40b7d
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Mon Jan 31 18:54:42 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2

commit 815cf8f
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:23:12 2022 +0100

    Use directive binding in mdc-dialog demo for align

commit 77fca70
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:20:43 2022 +0100

    Change actionsAlignment type in dialog demo

commit c87c4aa
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 00:21:57 2022 +0100

    Revert weird changes to dialog.spec.ts

commit d6deb45
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:30:24 2022 +0100

    Use 'start' as default instead of undefined for align attribute in dialog actions

commit 8d367c1
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:05:54 2022 +0100

    Update comments in dialog.scss for more clarity

commit 9d2ac16
Merge: 54d0a60 3de4ab8
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 22:33:13 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479

commit 54d0a60
Merge: 462d407 c79e1d1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:30:29 2022 +0100

    Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479

commit c79e1d1
Merge: 462d407 03485cd
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:23:17 2022 +0100

    Merge branch 'master' of https://github.com/angular/components into angular-master

commit 462d407
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:18:08 2020 +0100

    fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes #18479 for material-experimental

commit c101f7f
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:15:01 2020 +0100

    fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes #18479

* fixup! fix(material/dialog): Use align as @input() in MatDialogActions

ds

* fix(material/dialog): fix mismatching test names between mdc and non-mdc

* fix(material/dialog): fix mismatching test names between mdc and non-mdc

* fix(material/dialog): update golden api for dialog

* fix(material/dialog): Fix mdc action align test

* fix(material/dialog): update golden api for dialog

* fix(material/dialog): Fix mdc action align test

* fix(material/dialog): Squashed commit of the following:

commit 261cb7c
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:26:03 2022 +0100

    fix(material/dialog): Fix mdc action align test

commit b060272
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:10:12 2022 +0100

    fix(material/dialog): update golden api for dialog

commit 69491e1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 17:50:37 2022 +0100

    fix(material/dialog): fix mismatching test names between mdc and non-mdc

commit b4a9cb3
Author: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date:   Tue Feb 1 17:09:37 2022 +0100

    fixup! fix(material/dialog): Use align as @input() in MatDialogActions

    ds

commit d7a9cbb
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:27:13 2022 +0100

    fix(material/dialog): Use align as @input() in MatDialogActions

    Squashed commit of the following:

    commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
    Merge: 3276432 3a98da8
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 31 19:24:24 2022 +0100

        Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2

    commit 3276432
    Merge: 815cf8f 1f40b7d
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Mon Jan 31 18:54:42 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2

    commit 815cf8f
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:23:12 2022 +0100

        Use directive binding in mdc-dialog demo for align

    commit 77fca70
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:20:43 2022 +0100

        Change actionsAlignment type in dialog demo

    commit c87c4aa
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 00:21:57 2022 +0100

        Revert weird changes to dialog.spec.ts

    commit d6deb45
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:30:24 2022 +0100

        Use 'start' as default instead of undefined for align attribute in dialog actions

    commit 8d367c1
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:05:54 2022 +0100

        Update comments in dialog.scss for more clarity

    commit 9d2ac16
    Merge: 54d0a60 3de4ab8
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 22:33:13 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479

    commit 54d0a60
    Merge: 462d407 c79e1d1
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:30:29 2022 +0100

        Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479

    commit c79e1d1
    Merge: 462d407 03485cd
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:23:17 2022 +0100

        Merge branch 'master' of https://github.com/angular/components into angular-master

    commit 462d407
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:18:08 2020 +0100

        fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes #18479 for material-experimental

    commit c101f7f
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:15:01 2020 +0100

        fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes #18479

commit a74d92e
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 16:43:35 2022 +0100

    fix(material/menu): adjust overlay size when amount of items changes (#21457)

    Currently we lock the menu into a position after it is opened so that it doesn't jump
    around when the user scrolls, but this means that if the amount of items changes,
    it might not be the optimal position anymore.

    These changes add some code to re-calculate the position if the amount of items changes.

    Fixes #21456.

commit f201634
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 13:22:16 2022 +0100

    build: fix rules_sass error (#24331)

    Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
amysorto pushed a commit to amysorto/components that referenced this issue Feb 15, 2022
@crisbeto @amysorto
fix(material/menu): adjust overlay size when amount of items changes (a…
099e8d7 
…ngular#21457)

Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
amysorto pushed a commit to amysorto/components that referenced this issue Feb 15, 2022
@PooSham @devversion @amysorto
fix(material/dialog): Use align as @Input() in MatDialogActions (…
06648fa 
…angular#24328)

* fix(material/dialog): Use align as @input() in MatDialogActions

Squashed commit of the following:

commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
Merge: 3276432 3a98da8
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:24:24 2022 +0100

    Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 3276432
Merge: 815cf8f 1f40b7d
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Mon Jan 31 18:54:42 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 815cf8f
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:23:12 2022 +0100

    Use directive binding in mdc-dialog demo for align

commit 77fca70
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:20:43 2022 +0100

    Change actionsAlignment type in dialog demo

commit c87c4aa
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 00:21:57 2022 +0100

    Revert weird changes to dialog.spec.ts

commit d6deb45
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:30:24 2022 +0100

    Use 'start' as default instead of undefined for align attribute in dialog actions

commit 8d367c1
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:05:54 2022 +0100

    Update comments in dialog.scss for more clarity

commit 9d2ac16
Merge: 54d0a60 3de4ab8
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 22:33:13 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479

commit 54d0a60
Merge: 462d407 c79e1d1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:30:29 2022 +0100

    Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479

commit c79e1d1
Merge: 462d407 03485cd
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:23:17 2022 +0100

    Merge branch 'master' of https://github.com/angular/components into angular-master

commit 462d407
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:18:08 2020 +0100

    fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479 for material-experimental

commit c101f7f
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:15:01 2020 +0100

    fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479

* fix(material/dialog): Use align as @input() in MatDialogActions

Squashed commit of the following:

commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
Merge: 3276432 3a98da8
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:24:24 2022 +0100

    Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 3276432
Merge: 815cf8f 1f40b7d
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Mon Jan 31 18:54:42 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 815cf8f
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:23:12 2022 +0100

    Use directive binding in mdc-dialog demo for align

commit 77fca70
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:20:43 2022 +0100

    Change actionsAlignment type in dialog demo

commit c87c4aa
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 00:21:57 2022 +0100

    Revert weird changes to dialog.spec.ts

commit d6deb45
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:30:24 2022 +0100

    Use 'start' as default instead of undefined for align attribute in dialog actions

commit 8d367c1
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:05:54 2022 +0100

    Update comments in dialog.scss for more clarity

commit 9d2ac16
Merge: 54d0a60 3de4ab8
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 22:33:13 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479

commit 54d0a60
Merge: 462d407 c79e1d1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:30:29 2022 +0100

    Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479

commit c79e1d1
Merge: 462d407 03485cd
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:23:17 2022 +0100

    Merge branch 'master' of https://github.com/angular/components into angular-master

commit 462d407
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:18:08 2020 +0100

    fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479 for material-experimental

commit c101f7f
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:15:01 2020 +0100

    fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479

* fixup! fix(material/dialog): Use align as @input() in MatDialogActions

ds

* fix(material/dialog): fix mismatching test names between mdc and non-mdc

* fix(material/dialog): fix mismatching test names between mdc and non-mdc

* fix(material/dialog): update golden api for dialog

* fix(material/dialog): Fix mdc action align test

* fix(material/dialog): update golden api for dialog

* fix(material/dialog): Fix mdc action align test

* fix(material/dialog): Squashed commit of the following:

commit 261cb7c
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:26:03 2022 +0100

    fix(material/dialog): Fix mdc action align test

commit b060272
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:10:12 2022 +0100

    fix(material/dialog): update golden api for dialog

commit 69491e1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 17:50:37 2022 +0100

    fix(material/dialog): fix mismatching test names between mdc and non-mdc

commit b4a9cb3
Author: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date:   Tue Feb 1 17:09:37 2022 +0100

    fixup! fix(material/dialog): Use align as @input() in MatDialogActions

    ds

commit d7a9cbb
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:27:13 2022 +0100

    fix(material/dialog): Use align as @input() in MatDialogActions

    Squashed commit of the following:

    commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
    Merge: 3276432 3a98da8
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 31 19:24:24 2022 +0100

        Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2

    commit 3276432
    Merge: 815cf8f 1f40b7d
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Mon Jan 31 18:54:42 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2

    commit 815cf8f
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:23:12 2022 +0100

        Use directive binding in mdc-dialog demo for align

    commit 77fca70
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:20:43 2022 +0100

        Change actionsAlignment type in dialog demo

    commit c87c4aa
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 00:21:57 2022 +0100

        Revert weird changes to dialog.spec.ts

    commit d6deb45
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:30:24 2022 +0100

        Use 'start' as default instead of undefined for align attribute in dialog actions

    commit 8d367c1
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:05:54 2022 +0100

        Update comments in dialog.scss for more clarity

    commit 9d2ac16
    Merge: 54d0a60 3de4ab8
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 22:33:13 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479

    commit 54d0a60
    Merge: 462d407 c79e1d1
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:30:29 2022 +0100

        Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479

    commit c79e1d1
    Merge: 462d407 03485cd
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:23:17 2022 +0100

        Merge branch 'master' of https://github.com/angular/components into angular-master

    commit 462d407
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:18:08 2020 +0100

        fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes angular#18479 for material-experimental

    commit c101f7f
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:15:01 2020 +0100

        fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes angular#18479

commit a74d92e
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 16:43:35 2022 +0100

    fix(material/menu): adjust overlay size when amount of items changes (angular#21457)

    Currently we lock the menu into a position after it is opened so that it doesn't jump
    around when the user scrolls, but this means that if the amount of items changes,
    it might not be the optimal position anymore.

    These changes add some code to re-calculate the position if the amount of items changes.

    Fixes angular#21456.

commit f201634
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 13:22:16 2022 +0100

    build: fix rules_sass error (angular#24331)

    Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
fix(material/menu): adjust overlay size when amount of items changes (a…
c225824 
…ngular#21457)

Currently we lock the menu into a position after it is opened so that it doesn't jump
around when the user scrolls, but this means that if the amount of items changes,
it might not be the optimal position anymore.

These changes add some code to re-calculate the position if the amount of items changes.

Fixes angular#21456.
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@PooSham @devversion @forsti0506
fix(material/dialog): Use align as @Input() in MatDialogActions (…
37f1ec0 
…angular#24328)

* fix(material/dialog): Use align as @input() in MatDialogActions

Squashed commit of the following:

commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
Merge: 3276432 3a98da8
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:24:24 2022 +0100

    Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 3276432
Merge: 815cf8f 1f40b7d
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Mon Jan 31 18:54:42 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 815cf8f
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:23:12 2022 +0100

    Use directive binding in mdc-dialog demo for align

commit 77fca70
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:20:43 2022 +0100

    Change actionsAlignment type in dialog demo

commit c87c4aa
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 00:21:57 2022 +0100

    Revert weird changes to dialog.spec.ts

commit d6deb45
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:30:24 2022 +0100

    Use 'start' as default instead of undefined for align attribute in dialog actions

commit 8d367c1
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:05:54 2022 +0100

    Update comments in dialog.scss for more clarity

commit 9d2ac16
Merge: 54d0a60 3de4ab8
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 22:33:13 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479

commit 54d0a60
Merge: 462d407 c79e1d1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:30:29 2022 +0100

    Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479

commit c79e1d1
Merge: 462d407 03485cd
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:23:17 2022 +0100

    Merge branch 'master' of https://github.com/angular/components into angular-master

commit 462d407
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:18:08 2020 +0100

    fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479 for material-experimental

commit c101f7f
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:15:01 2020 +0100

    fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479

* fix(material/dialog): Use align as @input() in MatDialogActions

Squashed commit of the following:

commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
Merge: 3276432 3a98da8
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:24:24 2022 +0100

    Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 3276432
Merge: 815cf8f 1f40b7d
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Mon Jan 31 18:54:42 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2

commit 815cf8f
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:23:12 2022 +0100

    Use directive binding in mdc-dialog demo for align

commit 77fca70
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 01:20:43 2022 +0100

    Change actionsAlignment type in dialog demo

commit c87c4aa
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 10 00:21:57 2022 +0100

    Revert weird changes to dialog.spec.ts

commit d6deb45
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:30:24 2022 +0100

    Use 'start' as default instead of undefined for align attribute in dialog actions

commit 8d367c1
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 23:05:54 2022 +0100

    Update comments in dialog.scss for more clarity

commit 9d2ac16
Merge: 54d0a60 3de4ab8
Author: Jean-Philippe <jeanphilippe.green@gmail.com>
Date:   Sun Jan 9 22:33:13 2022 +0100

    Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479

commit 54d0a60
Merge: 462d407 c79e1d1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:30:29 2022 +0100

    Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479

commit c79e1d1
Merge: 462d407 03485cd
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Wed Jan 5 21:23:17 2022 +0100

    Merge branch 'master' of https://github.com/angular/components into angular-master

commit 462d407
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:18:08 2020 +0100

    fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479 for material-experimental

commit c101f7f
Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
Date:   Fri Dec 25 16:15:01 2020 +0100

    fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

    Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
    bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
    sense to assume end users to know they can use the align attribute.

    Fixes angular#18479

* fixup! fix(material/dialog): Use align as @input() in MatDialogActions

ds

* fix(material/dialog): fix mismatching test names between mdc and non-mdc

* fix(material/dialog): fix mismatching test names between mdc and non-mdc

* fix(material/dialog): update golden api for dialog

* fix(material/dialog): Fix mdc action align test

* fix(material/dialog): update golden api for dialog

* fix(material/dialog): Fix mdc action align test

* fix(material/dialog): Squashed commit of the following:

commit 261cb7c
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:26:03 2022 +0100

    fix(material/dialog): Fix mdc action align test

commit b060272
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 21:10:12 2022 +0100

    fix(material/dialog): update golden api for dialog

commit 69491e1
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Tue Feb 1 17:50:37 2022 +0100

    fix(material/dialog): fix mismatching test names between mdc and non-mdc

commit b4a9cb3
Author: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date:   Tue Feb 1 17:09:37 2022 +0100

    fixup! fix(material/dialog): Use align as @input() in MatDialogActions

    ds

commit d7a9cbb
Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
Date:   Mon Jan 31 19:27:13 2022 +0100

    fix(material/dialog): Use align as @input() in MatDialogActions

    Squashed commit of the following:

    commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3
    Merge: 3276432 3a98da8
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 31 19:24:24 2022 +0100

        Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2

    commit 3276432
    Merge: 815cf8f 1f40b7d
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Mon Jan 31 18:54:42 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2

    commit 815cf8f
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:23:12 2022 +0100

        Use directive binding in mdc-dialog demo for align

    commit 77fca70
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 01:20:43 2022 +0100

        Change actionsAlignment type in dialog demo

    commit c87c4aa
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Mon Jan 10 00:21:57 2022 +0100

        Revert weird changes to dialog.spec.ts

    commit d6deb45
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:30:24 2022 +0100

        Use 'start' as default instead of undefined for align attribute in dialog actions

    commit 8d367c1
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 23:05:54 2022 +0100

        Update comments in dialog.scss for more clarity

    commit 9d2ac16
    Merge: 54d0a60 3de4ab8
    Author: Jean-Philippe <jeanphilippe.green@gmail.com>
    Date:   Sun Jan 9 22:33:13 2022 +0100

        Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479

    commit 54d0a60
    Merge: 462d407 c79e1d1
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:30:29 2022 +0100

        Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479

    commit c79e1d1
    Merge: 462d407 03485cd
    Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com>
    Date:   Wed Jan 5 21:23:17 2022 +0100

        Merge branch 'master' of https://github.com/angular/components into angular-master

    commit 462d407
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:18:08 2020 +0100

        fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes angular#18479 for material-experimental

    commit c101f7f
    Author: Jean-Philippe Green <jeanphilippe.green@gmail.com>
    Date:   Fri Dec 25 16:15:01 2020 +0100

        fix(material/dialog): make align attribute into an input of dialog actions directive instead of css

        Fixes multiple issues, such as self-documentation of the align attribute, type checking, better
        bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much
        sense to assume end users to know they can use the align attribute.

        Fixes angular#18479

commit a74d92e
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 16:43:35 2022 +0100

    fix(material/menu): adjust overlay size when amount of items changes (angular#21457)

    Currently we lock the menu into a position after it is opened so that it doesn't jump
    around when the user scrolls, but this means that if the amount of items changes,
    it might not be the optimal position anymore.

    These changes add some code to re-calculate the position if the amount of items changes.

    Fixes angular#21456.

commit f201634
Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
Date:   Tue Feb 1 13:22:16 2022 +0100

    build: fix rules_sass error (angular#24331)

    Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/menu P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/menu): adjust overlay size when amount of items changes crisbeto/material2
2 participants
@crisbeto @DaxChen