Skip to content

Commit

Permalink
build: fix the approve-size-tests script (#29538)
Browse files Browse the repository at this point in the history
The `approve-size-tests` script was broken, because some private Tooling symbols were moved around. Also updates the golden file.

(cherry picked from commit 98f7301)
  • Loading branch information
crisbeto committed Aug 4, 2024
1 parent 0e1bf7c commit 27eb1db
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 24 deletions.
30 changes: 15 additions & 15 deletions goldens/size-test.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
cdk/drag-drop/all-directives: 153026
cdk/drag-drop/basic: 150520
material/autocomplete/without-optgroup: 274252
material/button-toggle/standalone: 188001
material/chips/basic: 260951
material/datepicker/range-picker/without-form-field: 400297
material/expansion/without-accordion: 197979
material/form-field/advanced: 263205
material/form-field/basic: 261635
material/list/nav-list: 218753
material/menu/without-lazy-content: 278141
material/radio/without-group: 199995
material/select/basic: 316667
material/tabs/advanced: 259447
material/tabs/basic: 259301
cdk/drag-drop/all-directives: 170299
cdk/drag-drop/basic: 166324
material/autocomplete/without-optgroup: 223062
material/button-toggle/standalone: 147380
material/chips/basic: 208741
material/datepicker/range-picker/without-form-field: 364729
material/expansion/without-accordion: 154530
material/form-field/advanced: 223916
material/form-field/basic: 222205
material/list/nav-list: 153825
material/menu/without-lazy-content: 221068
material/radio/without-group: 150402
material/select/basic: 269413
material/tabs/advanced: 217500
material/tabs/basic: 217357
2 changes: 1 addition & 1 deletion integration/size-test/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ esbuild_config(
name = "esbuild_config",
config_file = "esbuild.config.mjs",
deps = [
"@npm//@angular-devkit/build-angular",
"@npm//@angular/build",
"@npm//@angular/compiler-cli",
"@npm//@babel/core",
],
Expand Down
13 changes: 5 additions & 8 deletions integration/size-test/esbuild.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ import babel from '@babel/core';
import {createEs2015LinkerPlugin} from '@angular/compiler-cli/linker/babel';
import {ConsoleLogger, NodeJSFileSystem, LogLevel} from '@angular/compiler-cli';
import {GLOBAL_DEFS_FOR_TERSER_WITH_AOT} from '@angular/compiler-cli/private/tooling';
import adjustStaticClassMembersPlugin from '@angular-devkit/build-angular/src/babel/plugins/adjust-static-class-members.js';
import elideAngularMetadataPlugin from '@angular-devkit/build-angular/src/babel/plugins/elide-angular-metadata.js';
import adjustTypeScriptEnumsPlugin from '@angular-devkit/build-angular/src/babel/plugins/adjust-typescript-enums.js';
import pureToplevelFunctionsPlugin from '@angular-devkit/build-angular/src/babel/plugins/pure-toplevel-functions.js';
import ngBuild from '@angular/build/private';
import fs from 'fs';

/** Babel plugin running the Angular linker. */
Expand All @@ -35,17 +32,17 @@ const esbuildBabelOptimizePlugin = {
const content = await fs.promises.readFile(filePath, 'utf8');
const plugins = [
linkerBabelPlugin,
adjustStaticClassMembersPlugin,
elideAngularMetadataPlugin,
adjustTypeScriptEnumsPlugin,
ngBuild.adjustStaticMembers,
ngBuild.elideAngularMetadata,
ngBuild.adjustTypeScriptEnums,
];

// All files except for the auto-generated module entry-point are considered side-effect
// free. For these we can add the pure-top level Babel plugin. This matches conceptually
// with what is done in the Angular CLI compilation pipeline, with respect to everything
// in this repo being an official side-effect free APF package.
if (!args.path.includes('autogenerated_module_index.mjs')) {
plugins.push(pureToplevelFunctionsPlugin);
plugins.push(ngBuild.markTopLevelPure);
}

const {code} = await babel.transformAsync(content, {
Expand Down

0 comments on commit 27eb1db

Please sign in to comment.