Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19 #3578

Merged
merged 6 commits into from
Nov 20, 2024
Merged

v19 #3578

merged 6 commits into from
Nov 20, 2024

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 19, 2024

@jamesdaniels jamesdaniels enabled auto-merge (squash) November 20, 2024 04:21
@jamesdaniels jamesdaniels merged commit a58b329 into angular:main Nov 20, 2024
6 checks passed
@jamesdaniels jamesdaniels deleted the v19 branch November 20, 2024 04:22
@damingerdai
Copy link

please release new version

@quedicesebas
Copy link

quedicesebas commented Nov 22, 2024

What changes in the API? I'm getting these errors after upgrading:

FirebaseError: Expected type '_Query', but it was: a custom _DocumentReference object

and

FirebaseError: Type does not match the expected instance. Did you pass a reference from a different Firestore SDK?

Maybe a problem with rxfire that has the dependency set to v10 instead of 11?

@quedicesebas
Copy link

What changes in the API? I'm getting these errors after upgrading:

FirebaseError: Expected type '_Query', but it was: a custom _DocumentReference object

and

FirebaseError: Type does not match the expected instance. Did you pass a reference from a different Firestore SDK?

Maybe a problem with rxfire that has the dependency set to v10 instead of 11?

Adding firebase as dependency in my project resolves the problem (but it was originated by the rxfire library.

@jamesdaniels
Copy link
Member Author

Yeah that's right. Poor error message when it's two conflicting versions of the SDK. I'm updating RxFire next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing @angular/fire on IDX adds an unrecognized locationId
3 participants