Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

I discovered that IE7 and IE8 throw a javascript error on delete window[... #649

Closed
wants to merge 1 commit into from

Conversation

nateflink
Copy link

I discovered that IE7 and IE8 throw a javascript error on

delete window[callbackId];

The specific IE7/8 error reported is:
Message: Object doesn't support this action

Doesn't seem to be a problem in IE9, Chrome, or Firefox
thanks guys, you rock!

@IgorMinar
Copy link
Contributor

Interestingly there is angularCallbacks and angular.callbacks defined in src/Angular.js, but nobody uses it. We should kill it in favor of using AngularPublic.js and using a simple object instead of extensionMap.

@IgorMinar
Copy link
Contributor

@dmanek offered to take care of this

@IgorMinar
Copy link
Contributor

so to reiterate the solutions consists of:

  • remove angularCallbacks from Angular.js
  • add callbacks: {} to AngularPublic.js
  • change Browser to register and delete the callbacks on angular.callbacks

@IgorMinar
Copy link
Contributor

fixed by #668

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants