This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Improve ng style #640
Closed
Improve ng style #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
several tests are failing: http://ci.angularjs.org/job/angular.js-igor/298/ |
|
I updated the test & ran them on Chrome 15 & 17, Opera, Safari and Firefox (all on Mac) and no tests are failing. Will have to run on IE on the CI server to ensure all tests pass. |
|
All tests pass now: http://ci.angularjs.org/job/angular.js-dhruv/8/ |
| styleToRemove = oldVal || {}, | ||
| key; | ||
| for(key in styleToRemove) | ||
| element.css(key, ''); |
|
I'll go ahead and fix the style issues.. the comments are just FYI |
|
landed as e2663f6 |
This was referenced May 29, 2020
This was referenced Dec 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved and unobtrusive ng:style