Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(q.js): if rejection handler throws an exception, reject promise #3697

Closed
wants to merge 1 commit into from

Conversation

jamestalmage
Copy link
Contributor

per Promise/A+ spec

@jamestalmage
Copy link
Contributor Author

This (in conjunction with latest on master) will make the tests pass.

I'm suspicious that similar try/catch wrapping should be done in ref implementation here. But the tests pass without it.

@IgorMinar
Copy link
Contributor

ref is currently never called or exposed in a way that would allow non-$q listeners to be registered with its promise. though it does make me a bit nervous having it there exposed waiting for someone to change $q.js in a way where the previous statement would not be true any more.

I'm going to close this as dupe of #3699 since I've already implemented this change and included tests.

thanks

@IgorMinar IgorMinar closed this Aug 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants