feat (ng-pluralize): add alternative mapping using attributes

[lgalfaso]

When using ngPluralize, I found myself having to escape the characters " and '.
This PR adds an alternative way to define the mapping using attributes to the element like this

<ng:pluralize count='viewCount' offset='1'
    _0='Nobody is viewing.'
    _1='{{p1}} is viewing.'
    one='{{p1}} and one other person are viewing.'
    other='{{p1}} and {} other people are viewing.'>
</ng:pluralize>

[IgorMinar]

I'm not keen on this syntax as it requires the _NUM hack. Could we use the body of the element or prefix all attributes with "when-" instead?

[petebacondarwin]

+1 for when-X="..."

I am also rather drawn to the idea of using inner elements, which would allow us to have HTML and directives inside the templates. But working with transclusion in this way is rather problematic right now so probably for the future.

<ng-pluralize count="viewers.count' offset='1' ng-init="viewers="['a', 'b', 'c']">
  <ng-pluralize-template when="0">Nobody is viewing</ng-pluralize-template>
  <ng-pluralize-template when="1">
    <a ng-click="showViewer(0)">{{viewers[0]}}</a> is viewing
  </ng-pluralize-template>
  <ng-pluralize-template when="one">
    <a ng-click="showViewer(0)">{{viewers[0]}}</a> and
    <a ng-click="showViewer(0)">{{viewers[1]}}</a> are viewing
  </ng-pluralize-template>
  <ng-pluralize-template when="other">
    <div>{{viewers[0] and {{$offsetCount}} are viewing</div>
    <div>{{$count}} are viewing</div>
  </ng-pluralize-template>
</ng-pluralize>

[lgalfaso]

I like the idea of a when-X attribute, will look into making the changes so it works this way. Agree that with the current state of transclusion, having the second proposal from @petebacondarwin can be an issue

[petebacondarwin]

@lgalfaso - Great! How are you getting on making the change to when- style attributes?

[lgalfaso]

@petebacondarwin The change is simple, I am just trying to figure out how to handle negative numbers in a visually appealing way. Does when--2 looks ok for -2?

[petebacondarwin]

when-minus-2?

Pete
...from my mobile.
On May 8, 2013 4:03 PM, "Lucas Galfasó" notifications@github.com wrote:

@petebacondarwin https://github.com/petebacondarwin The change is
simple, I am just trying to figure out how to handle negative numbers in a
visually appealing way. Does when--2 looks ok for -2?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2454#issuecomment-17611604
.

[lgalfaso]

@petebacondarwin Looks like a good alternative. Just push a new patch

[petebacondarwin]

This line is a bit unclear. Perhaps it could be something like this

You configure ngPluralize by providing attributes, count, when and offset to describe what should be counted and how to map that count to templates for display.

And then enumerate the attributes and how they work below.

[lgalfaso]

Thanks changed

[petebacondarwin]

Also, what happens if someone tries to use both strategies? It seems that at the moment both configurations are used with the when-X attributes overriding what is in the when="{}" object. Is this what you expect and if so we ought to make it explicit in the text and the documentation.

[lgalfaso]

@petebacondarwin Added the following comment to clarify what happens when the two mapping mechanisms are used

It is possible to mix the two forms to define a mapping. In this case, if there is a conflict the definition used using when will take precedence.

[lgalfaso]

@petebacondarwin Thanks for looking into this, and let me know if you would like me to rebase this into a single commit

[IgorMinar]

shouldn't this be when-one and when-other below?

[lgalfaso]

The idea is to accept the unicode plural categories as-is, without the when- prefix. Can change this to be when- prefixed if you think it would make more sense

[petebacondarwin]

I think when-... throughout it definitely the way forward. It helps make it clear what you are talking about.

[lgalfaso]

I like this being consistent, changed

[IgorMinar]

the rest looks good to me

[lgalfaso]

Please let me know if you would like me to rebase this into a single commit

[pkozlowski-opensource]

@lgalfaso yes, squasing commits would be helpful - would make it easier to review and merge

[lgalfaso]

@pkozlowski-opensource sure, done

[IgorMinar]

LGTM.

@pkozlowski-opensource please merge

[pkozlowski-opensource]

on it

[pkozlowski-opensource]

@lgalfaso Sorry for being pain in a neck but 2ff7a69 is based on the 3-months old master and doesn't merge cleanly. I was trying to merge it in pkozlowski-opensource@f9c75e4 but after the merge there are several test failrues (different ones on different browsers), see:
http://ci.angularjs.org/job/angular.js-pawel/110/console

Not sure if this is due to my merges or there is something else going on so it would be awesome if you could have a look. Thnx!

[lgalfaso]

@pkozlowski-opensource 5e8dfe1 is a clean merge to master

[pkozlowski-opensource]

@lgalfaso merges cleanly now but there are 2 tests failures on IE8:
http://ci.angularjs.org/job/angular.js-pawel/112/console

When pushing a fix for those tests could you make sure that there is only one commit in the lgalfaso:easy-pluralize branch? (just push forced update). This would make my life easier!

[lgalfaso]

@pkozlowski-opensource I do not have access to an IE8, but I think that 9e5876f will make IE8 happy

[pkozlowski-opensource]

Bingo, lgalfaso@9e5876f did the trick.

Landed as a170fc1. Thank you!