fix($browser): cookiePath now defaults to '' when basePath is undefined

[fredrikbonander]

As described in issue #1191 Safari and IE fails if the cookiePath is undefined.

[IgorMinar]

better fix would be to fix the baseHref method not to return undefined:

return href ? href.replace(/^https?\:\/\/[^\/]*/, '') : href;

should be:

return href ? href.replace(/^https?\:\/\/[^\/]*/, '') : '';

can you also write a test for the $browser.cookies api that will verify that the cookie path is set to empty string by default even if the base element is undefined?

[fredrikbonander]

@IgorMinar Sure, it was my first thought but in https://github.com/angular/angular.js/blob/master/test/ng/browserSpecs.js#L558 there's a test verifying that basePath is undefined. If I modify it and remove the test for undefined would this be considered a breaking change?

[IgorMinar]

that test is unnecessarily strict. I think that it's fine to change it to return "" when baseElement doesn't exist

[fredrikbonander]

I'm not entirely happy with the test, I would like to test that the correct path is set for a cookie. But since it's not available this might due.

[IgorMinar]

PR Checklist (Minor Bugfix)

• Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
• PR doesn't introduce new api
• PR doesn't contain a breaking change
• PR contains unit tests
• [-] PR contains e2e tests (if suitable)
• [-] PR contains documentation update (if suitable)
• PR passes all tests on Travis (sanity)
• PR passes all tests on ci.angularjs.org (cross-browser compatibility)
• PR is rebased against recent master
• PR is squashed into one commit per logical change
• PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
• All changes requested in review have been implemented

[IgorMinar]

landed as 7cb8f8f

thanks!

if you haven't received our t-shirt before and would like one please fill out this form: http://goo.gl/075Sj

[IgorMinar]

oops should be 7cb8f8f