This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(removePatch): fire $destroy event when full jQuery is used #1509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch corrects a problem observed when using ngRepeat to create required inputs inside a form. If the user removed the text from an input (making it invalid) and then carried out an action to delete the appropriate part of the model then the input element was never removed from the form, causing the form to stay $invalid although in fact all current elements were $valid. Because the form then had an invalid validation token retained for a destroyed control it was not possible to recover the correct state for the form without destroying it.
The previous code relied upon internal jQuery structures which are not present in v.1.8.2 (current). This code uses the public API to fire the $destroy custom event, and so should work with any post-1.4 jQuery version.