Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Commit

Permalink
chore(ci): avoid unnecessarily running grunt prepareDeploy in `depl…
Browse files Browse the repository at this point in the history
…oy-docs` CI job

Previously, the `grunt prepareDeploy` command was run in both the
`prepare-deployment` and `deploy-docs` CI jobs. The reason was that not
all files affected by `grunt prepareDeploy` were persisted to the
workspace across jobs.

More specifically, the command would affect files in the `deploy/` and
`scripts/docs.angularjs.org-firebase/` directories and also create a
`firebase.json` file at the root directory, but only the `deploy/`
directory was [persisted to the workspace][1].

This commit avoids unnecessarily running the `grunt prepareDeploy`
command in the `deploy-docs` CI job by ensuring that all affected files
will be persisted to the workspace in the `prepare-deployment` CI job,
which always runs before `deploy-docs`.

[1]: https://github.com/angular/angular.js/blob/295213df953766625462/.circleci/config.yml#L265

Closes #17060
  • Loading branch information
gkalpak committed Aug 13, 2020
1 parent 0468870 commit 83f084e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ jobs:
- persist_to_workspace:
root: *workspace_location
paths:
- ./ng/deploy
- ./ng

# The `deploy-code` job should only run when all of these conditions are true for the build:
# - It is for the `angular/angular.js` repository (not a fork).
Expand Down Expand Up @@ -383,7 +383,6 @@ jobs:
- custom_attach_workspace
- init_environment
- skip_unless_stable_branch
- run: yarn grunt prepareDeploy
# Install dependencies for Firebase functions to prevent parsing errors during deployment
# See https://github.com/angular/angular.js/pull/16453
- run: yarn -cwd ~/ng/scripts/docs.angularjs.org-firebase/functions
Expand Down

0 comments on commit 83f084e

Please sign in to comment.