fix(@angular-devkit/build-angular): use a dash in bundle names #25877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55ed9a0 to
2c82be4
Compare
|
I'm missing something in the PR, but I can't figure out what as I don't know these parts well enough... Do you have an insight? |
alan-agius4
reviewed
Sep 21, 2023
| // The first part of the filename is the name of file (e.g., "polyfills" for "polyfills.7S5G3MDY.js") | ||
| const name = basename(relativeFilePath).split('.', 1)[0]; | ||
| // The first part of the filename is the name of file (e.g., "polyfills" for "polyfills-7S5G3MDY.js") | ||
| const name = basename(relativeFilePath).split('-', 1)[0]; |
There was a problem hiding this comment.
This line is causing the problem as the extension is no longer removed. Also in the case using slice can cause problems for entrypoints name with a dashed Example material-styles.css. I propose to you a regexp.
Suggested change
| const name = basename(relativeFilePath).split('-', 1)[0]; | |
| const name = basename(relativeFilePath).replace(/(?:-[\dA-Z]{8})?\.[a-z]{2,3}$/, ''); |
There was a problem hiding this comment.
Thanks Alan, let's try that
7b6360c to
00acb46
Compare
This updates the esbuild based builder to use a dash in bundles and media instead of a dot to be consistent with the chunks files `chunk-xxx.js`.
00acb46 to
2fe2a1c
Compare
|
I had to change a few tests, but CI is now green. Thanks for the help @alan-agius4 |
alan-agius4
approved these changes
Sep 21, 2023
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Sep 22, 2023
…e name This update the regexp to account for the change in angular#25877
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Sep 22, 2023
…e name This update the regexp to account for the change in angular#25877 A filename that has the hash included will be `main.[hash]` in Webpack and `main-[hash]` when using esbuild.
alan-agius4
added a commit
that referenced
this pull request
Sep 22, 2023
…e name This update the regexp to account for the change in #25877 A filename that has the hash included will be `main.[hash]` in Webpack and `main-[hash]` when using esbuild.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The files generated by the esbuild-based builder are named
main.xxx.js,polyfills.xxx.jsbut the chunks are namedchunk-xxx.jsWhat is the new behavior?
This updates the esbuild-based builder to use a dash in bundles and media instead of a dot to be consistent with the chunks files
chunk-xxx.js.Does this PR introduce a breaking change?
Other information