fix(uiSelectChoices): prevent template element from being modified #1850
Conversation
Previously, the .ui-select-choices-row element got deleted whenever the linked scope got destroyed which prevents rendering of the options in some cases.
|
@zollinger I'm going assume this is in reference to #1365? I need one of you to open an issue with a Repro just to confirm there is a problem and this does resolve it, before I go ahead and merge. (Up until no one else has reported this problem and there have been many versions since the changes - so I just want to be sure this is good to merge). |
…ate element in link function
|
I added a second commit which prevents tElement from leaking to the link function scope. |
|
@zollinger I was thinking to ask you to do that. Thanks very much! Just before I merge is there anyway we can add a test for this? |
|
I'm not entirely sure what to test here. Adding and removing elements to the DOM is the job of AngularJS, so I we should do or test that here. Then the second change is about working with the linked element in link phase, which is obvious. |
…ngular-ui#1850) * fix(uiSelectChoices): prevent template element from being modified Previously, the .ui-select-choices-row element got deleted whenever the linked scope got destroyed which prevents rendering of the options in some cases. * fix(uiSelectChoicesDirective): use element reference instead of template element in link function Closes angular-ui#1851
Previously, the .ui-select-choices-row element got deleted whenever the linked scope got destroyed which prevents rendering of the options in some cases.